Skip to content

Fix F# compiler to prevent tail call emission when pinned locals are present #18893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 19, 2025
+76 −2
Merged

Fix F# compiler to prevent tail call emission when pinned locals are present #18893

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ebfe93e
Initial plan
Copilot Sep 8, 2025
63fc090
Add tracking for pinned locals in TailCallChecks (WIP)
Copilot Sep 8, 2025
ce1a97f
Add pinned locals tracking to IlxGen (still WIP - tail calls not bloc…
Copilot Sep 8, 2025
ff7379c
Implement fix to prevent tail calls when pinned locals are present
Copilot Sep 8, 2025
3c000d9
Fix PR review comments: remove mutable, gitignore .trx files, add rec…
Copilot Sep 17, 2025
b4edc34
Move release notes from 9.0.300 to 10.0.100 as requested
Copilot Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,416 changes: 1,416 additions & 0 deletions TestResults/_pkrvm7jw40e0xgp_2025-09-08_16_18_58.trx
View file
Open in desktop

Large diffs are not rendered by default.

45 changes: 45 additions & 0 deletions TestResults/_pkrvm7jw40e0xgp_2025-09-08_16_19_44.trx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<?xml version="1.0" encoding="utf-8"?>
<TestRun id="a784b02e-5b49-4370-acfb-8134e0ba55d6" name="@pkrvm7jw40e0xgp 2025-09-08 16:19:44" xmlns="http://microsoft.com/schemas/VisualStudio/TeamTest/2010">
<Times creation="2025-09-08T16:19:44.1705198+00:00" queuing="2025-09-08T16:19:44.1705199+00:00" start="2025-09-08T16:19:42.5797634+00:00" finish="2025-09-08T16:19:44.1710508+00:00" />
<TestSettings name="default" id="30dd843b-5391-43d8-bd1e-309d70ae7da1">
<Deployment runDeploymentRoot="_pkrvm7jw40e0xgp_2025-09-08_16_19_44" />
</TestSettings>
<TestLists>
<TestList name="Results Not in a List" id="8c84fa94-04c1-424b-9868-57a2d4851a1d" />
<TestList name="All Loaded Results" id="19431567-8539-422a-85d7-44ee4e166bda" />
</TestLists>
<ResultSummary outcome="Completed">
<Counters total="0" executed="0" passed="0" failed="0" error="0" timeout="0" aborted="0" inconclusive="0" passedButRunAborted="0" notRunnable="0" notExecuted="0" disconnected="0" warning="0" completed="0" inProgress="0" pending="0" />
<Output>
<StdOut>[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0-rc.1.25411.109)
Installing TestConsole redirection
---------------------------------------------------------------
Executables
CSC = /home/runner/.nuget/packages/microsoft.net.compilers/4.3.0-1.22220.8/tools/csc.exe
BUILD_CONFIG = Release
csc_flags = /nologo
FSC = /home/runner/work/fsharp/fsharp/tests/FSharp.Test.Utilities/../../artifacts/bin/fsc/Release/net10.0/fsc.dll
fsc_flags = -r:System.Core.dll --nowarn:20 --define:COMPILED --preferreduilang:en-US
FSCOREDLLPATH = /home/runner/work/fsharp/fsharp/tests/FSharp.Test.Utilities/../../artifacts/bin/FSharp.Core/Release/netstandard2.0/FSharp.Core.dll
FSI = /home/runner/work/fsharp/fsharp/tests/FSharp.Test.Utilities/../../artifacts/bin/fsi/Release/net10.0/fsi.dll
DotNetExe = dotnet
DOTNET_MULTILEVEL_LOOKUP = 0
DOTNET_ROOT = /usr/share/dotnet
FSI_FOR_SCRIPTS = /home/runner/work/fsharp/fsharp/tests/FSharp.Test.Utilities/../../artifacts/bin/fsi/Release/net10.0/fsi.dll
fsi_flags = -r:System.Core.dll --nowarn:20 --define:INTERACTIVE --maxerrors:1 --abortonerror --preferreduilang:en-US
ILDASM = /home/runner/.nuget/packages/runtime.linux-x64.microsoft.netcore.ildasm/5.0.0-preview.7.20364.11/runtimes/linux-x64/native/ildasm
PEVERIFY = ilverify
---------------------------------------------------------------
[xUnit.net 00:00:00.16] Discovering: FSharp.Compiler.ComponentTests
[xUnit.net 00:00:01.11] Discovered: FSharp.Compiler.ComponentTests
[xUnit.net 00:00:01.12] Starting: FSharp.Compiler.ComponentTests
[xUnit.net 00:00:01.14] Finished: FSharp.Compiler.ComponentTests
</StdOut>
</Output>
<RunInfos>
<RunInfo computerName="pkrvm7jw40e0xgp" outcome="Warning" timestamp="2025-09-08T16:19:44.1026876+00:00">
<Text>No test matches the given testcase filter `FullyQualifiedName~'TailCall 06'` in /home/runner/work/fsharp/fsharp/artifacts/bin/FSharp.Compiler.ComponentTests/Release/net10.0/FSharp.Compiler.ComponentTests.dll</Text>
</RunInfo>
</RunInfos>
</ResultSummary>
</TestRun>
45 changes: 45 additions & 0 deletions TestResults/_pkrvm7jw40e0xgp_2025-09-08_16_19_56.trx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
<?xml version="1.0" encoding="utf-8"?>
<TestRun id="eb0cc85b-329d-4d10-8b7a-043a8e852caa" name="@pkrvm7jw40e0xgp 2025-09-08 16:19:56" xmlns="http://microsoft.com/schemas/VisualStudio/TeamTest/2010">
<Times creation="2025-09-08T16:19:56.0180601+00:00" queuing="2025-09-08T16:19:56.0180601+00:00" start="2025-09-08T16:19:54.3391211+00:00" finish="2025-09-08T16:19:56.0185438+00:00" />
<TestSettings name="default" id="37e8b09d-32a4-4772-ae12-017331dd61e2">
<Deployment runDeploymentRoot="_pkrvm7jw40e0xgp_2025-09-08_16_19_56" />
</TestSettings>
<TestLists>
<TestList name="Results Not in a List" id="8c84fa94-04c1-424b-9868-57a2d4851a1d" />
<TestList name="All Loaded Results" id="19431567-8539-422a-85d7-44ee4e166bda" />
</TestLists>
<ResultSummary outcome="Completed">
<Counters total="0" executed="0" passed="0" failed="0" error="0" timeout="0" aborted="0" inconclusive="0" passedButRunAborted="0" notRunnable="0" notExecuted="0" disconnected="0" warning="0" completed="0" inProgress="0" pending="0" />
<Output>
<StdOut>[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0-rc.1.25411.109)
Installing TestConsole redirection
---------------------------------------------------------------
Executables
CSC = /home/runner/.nuget/packages/microsoft.net.compilers/4.3.0-1.22220.8/tools/csc.exe
BUILD_CONFIG = Release
csc_flags = /nologo
FSC = /home/runner/work/fsharp/fsharp/tests/FSharp.Test.Utilities/../../artifacts/bin/fsc/Release/net10.0/fsc.dll
fsc_flags = -r:System.Core.dll --nowarn:20 --define:COMPILED --preferreduilang:en-US
FSCOREDLLPATH = /home/runner/work/fsharp/fsharp/tests/FSharp.Test.Utilities/../../artifacts/bin/FSharp.Core/Release/netstandard2.0/FSharp.Core.dll
FSI = /home/runner/work/fsharp/fsharp/tests/FSharp.Test.Utilities/../../artifacts/bin/fsi/Release/net10.0/fsi.dll
DotNetExe = dotnet
DOTNET_MULTILEVEL_LOOKUP = 0
DOTNET_ROOT = /usr/share/dotnet
FSI_FOR_SCRIPTS = /home/runner/work/fsharp/fsharp/tests/FSharp.Test.Utilities/../../artifacts/bin/fsi/Release/net10.0/fsi.dll
fsi_flags = -r:System.Core.dll --nowarn:20 --define:INTERACTIVE --maxerrors:1 --abortonerror --preferreduilang:en-US
ILDASM = /home/runner/.nuget/packages/runtime.linux-x64.microsoft.netcore.ildasm/5.0.0-preview.7.20364.11/runtimes/linux-x64/native/ildasm
PEVERIFY = ilverify
---------------------------------------------------------------
[xUnit.net 00:00:00.17] Discovering: FSharp.Compiler.ComponentTests
[xUnit.net 00:00:01.17] Discovered: FSharp.Compiler.ComponentTests
[xUnit.net 00:00:01.18] Starting: FSharp.Compiler.ComponentTests
[xUnit.net 00:00:01.19] Finished: FSharp.Compiler.ComponentTests
</StdOut>
</Output>
<RunInfos>
<RunInfo computerName="pkrvm7jw40e0xgp" outcome="Warning" timestamp="2025-09-08T16:19:55.9494939+00:00">
<Text>No test matches the given testcase filter `FullyQualifiedName~TailCall06` in /home/runner/work/fsharp/fsharp/artifacts/bin/FSharp.Compiler.ComponentTests/Release/net10.0/FSharp.Compiler.ComponentTests.dll</Text>
</RunInfo>
</RunInfos>
</ResultSummary>
</TestRun>
Loading
Loading