-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Enabling more UI Tests by removing platform specific condition - 5 #27564
base: main
Are you sure you want to change the base?
[Testing] Enabling more UI Tests by removing platform specific condition - 5 #27564
Conversation
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@@ -21,5 +20,4 @@ public void GradientAndShadowShouldWork() | |||
VerifyScreenshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending snapshot on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have committed this snapshot in the latest changes.
@@ -21,5 +20,4 @@ public void CollectionViewShouldHaveScrollBar() | |||
VerifyScreenshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz Since the scrollbar in the CollectionView fades out during screenshots on iOS, it's difficult to verify its visibility in UI tests. I will disable this test case for iOS; please share any suggestions you have.
@@ -20,5 +19,4 @@ public void CustomStyleEditorFromPlatformViewWorks() | |||
VerifyScreenshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending snapshot on macOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have committed this snapshot in the latest changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending on macOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending on macOS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz Since the Entry control is not focusing during screenshots on MacCatalyst, the Clear Button is not visible, so I will disable this test case for Mac.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've changed the logic for taking screenshots on macOS. It has been optimized, now instead of setting the App to full screen and taking the screenshot, we directly get the Window position and size and create a snapshot by cropping the App's content from the screen.
This requires re-committing the updated macOS screenshots.
src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/CollectionViewShouldHaveScrollBar.png
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 5th group of tests enabled.
Test Cases:
Fixes #22902