Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Enabling more UI Tests by removing platform specific condition - 5 #27564

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue25473.xaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<?xml version="1.0" encoding="UTF-8"?>
<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
xmlns:local="clr-namespace:Maui.Controls.Sample.Issues"
xmlns:local="clr-namespace:Maui.Controls.Sample"
x:Class="Maui.Controls.Sample.Issues.Issue25473">

<VerticalStackLayout Spacing="20" HorizontalOptions="Center">
<!-- Entry control with ClearButtonVisibility set to 'WhileEditing' -->
<HorizontalStackLayout>
<Entry
<local:UITestEntry
x:Name="mainEntryField"
AutomationId="MainEntryField"
BackgroundColor="Transparent"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
namespace Maui.Controls.Sample.Issues
{

[Issue(IssueTracker.Github, 25473, "MAUI Entry in Windows always shows ClearButton despite ClearButtonVisibility set to 'Never'", PlatformAffected.UWP)]
[Issue(IssueTracker.Github, 25473, "MAUI Entry in Windows always shows ClearButton despite ClearButtonVisibility set to Never", PlatformAffected.UWP)]
public partial class Issue25473 : ContentPage
{
public Issue25473()
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if ANDROID
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand Down Expand Up @@ -28,8 +27,7 @@ public void ScrollViewInHeaderDisposesProperly()
App.WaitForElement(Back);
App.Tap(Back);

App.WaitForNoElement(Success);
App.WaitForElement(Success);
}
}
}
#endif
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if !MACCATALYST
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -24,5 +23,4 @@ public void BackButtonBehaviorIsVisibleWorksWithCustomIcon()
VerifyScreenshot();
}
}
}
#endif
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#if ANDROID
#if TEST_FAILS_ON_WINDOWS //SearchHandler Fails to Trigger Focused Event on Windows, for more information: https://github.com/dotnet/maui/issues/27551
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if ANDROID
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -22,9 +21,8 @@ public Issue2482(TestDevice testDevice) : base(testDevice)
public void AnimationCancel()
{
App.WaitForElement(ButtonId);
App.DoubleClick(ButtonId);
App.WaitForNoElement(Success, timeout: TimeSpan.FromSeconds(25));
App.DoubleTap(ButtonId);
App.WaitForElement(Success);
}
}
}
#endif
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#if ANDROID
# if ANDROID //This sample includes Android-specific customization for the CollectionView handler using conditional compilation.
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#if WINDOWS
#if TEST_FAILS_ON_CATALYST
//In MacCatalyst platform, the Clear Button in the Entry control is not visible during screenshots, but this issue is fixed after enabling the test for verifyScreenshot (https://github.com/dotnet/maui/pull/27531).
using Microsoft.Maui.Platform;
using NUnit.Framework;
using UITest.Appium;
Expand All @@ -12,8 +13,7 @@ public Issue25473(TestDevice testDevice) : base(testDevice)
{
}

public override string Issue => "MAUI Entry in Windows always shows ClearButton despite ClearButtonVisibility set to 'Never'";

public override string Issue => "MAUI Entry in Windows always shows ClearButton despite ClearButtonVisibility set to Never";
[Test]
[Category(UITestCategories.Entry)]
public void VerifyEntryClearButtonVisibilitySetToWhileEditing()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if WINDOWS
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -20,5 +19,4 @@ public void CustomStyleEditorFromPlatformViewWorks()
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshot on macOS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed this snapshot in the latest changes.

}
}
}
#endif
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#if ANDROID || IOS
using NUnit.Framework;
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

Expand All @@ -21,5 +20,4 @@ public void GradientAndShadowShouldWork()
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshot on Windows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed this snapshot in the latest changes.

}
}
}
#endif
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
#if ANDROID || IOS
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;
Expand All @@ -19,8 +18,7 @@ public void UpdatedBackButtonTitleForEmptyString()
{
App.WaitForElement("GotoPage2");
App.Tap("GotoPage2");
VerifyScreenshot();
App.WaitForElement("Welcome to Page 2");
}
}
}
#endif
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.