Use <sys/ucontext.h> instead of <ucontext.h> #110023
Conversation
dotnet-policy-service
bot
added
the
community-contribution
| #include <sys/ucontext.h> | ||
| #else | ||
| #include <ucontext.h> | ||
| #endif |
There was a problem hiding this comment.
Please upstream this patch (https://github.com/libunwind/libunwind) and add a line next to
The next update (v1.9) will automatically pick it up from upstream, eliminating the need for manual verification on our end.
There was a problem hiding this comment.
This is just CI test at this point. This should not even be used on Apple platforms but I think DAC references it for one reason or another. I'd rather resolve that and drop the change in libunwind.
There was a problem hiding this comment.
Yup, windows and macOS only use HP libunwind for remote unwinding feature. It's a bit unfortunately that llvm-libunwind doesn't provide that and HP libunwind doesn't fully support macOS. Converging to one lib was attempted a few times but there isn't a substantial progress on that front. :(
Apple's implementation of
<ucontext.h>only works with the_XOPEN_SOURCEdefinition and contains some deprecated functions that .NET never really references. Let's ask the CI if using a more specific header is an option.