[NativeAOT-LLVM] Port (most of) compiler-generated helpers to WASM #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SingleAccretion
changed the title
SingleAccretion
force-pushed
the
WOW2
branch
2 times, most recently
from
262417c
to
8eb3e24
Compare
|
@dotnet/nativeaot-llvm |
maraf
added
the
area-NativeAOT-LLVM
yowl
approved these changes
Aug 6, 2024
Just that little bit :). After the extern method accessor nodes are rewritten in the same way, all LLVM interop can be deleted from ILC. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2643.
The handwritten helpers offer a minor (-1K code size on HelloWasm) CQ improvement, mostly because LLVM is quite aggressive in inlining
i32.constrelocations, which are 5 bytes large without compression.The accessor nodes will require some additions to the object writer and so have been left for the next change. After that is done, interop added in https://github.com/dotnet/runtimelab/pull/2615/files can also be deleted.