Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize assemblies redistributed in Containers folders #41737

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

rainersigwald
Copy link
Member

Drop a bunch of content from Containers

I don't feel like doing the math

Mode:  Differences
Left base folder: C:\Users\raines\Downloads\dotnet-sdk-9.0.100-preview.5.24307.3-win-x64\sdk\9.0.100-preview.5.24307.3\Containers
Right base folder: S:\sdk\artifacts\bin\redist-installer\Debug\dotnet\sdk\9.0.100-dev\Containers

Left Orphan Files (50)                                                 Size
--------------------------------------------------------------------------------
containerize\MSBuild.dll                                                 362,672
tasks\net9.0\Microsoft.DotNet.Cli.Utils.dll                              264,480
tasks\net9.0\Microsoft.Extensions.DependencyInjection.Abstractions.dll   145,688
tasks\net9.0\Microsoft.Extensions.DependencyInjection.dll                215,312
tasks\net9.0\Microsoft.Extensions.DependencyModel.dll                    190,640
tasks\net9.0\Microsoft.Extensions.Logging.Abstractions.dll               145,680
tasks\net9.0\Microsoft.Extensions.Logging.dll                            100,624
tasks\net9.0\Microsoft.Extensions.Options.dll                            141,576
tasks\net9.0\Microsoft.Extensions.Primitives.dll                          84,256
tasks\net9.0\MSBuild.dll                                                 837,920
tasks\net9.0\Newtonsoft.Json.dll                                       1,857,592
tasks\net9.0\NuGet.Common.dll                                            305,440
tasks\net9.0\NuGet.Configuration.dll                                     469,264
tasks\net9.0\NuGet.DependencyResolver.Core.dll                           247,968
tasks\net9.0\NuGet.Frameworks.dll                                        362,760
tasks\net9.0\NuGet.LibraryModel.dll                                      133,296
tasks\net9.0\NuGet.Packaging.dll                                       1,702,048
tasks\net9.0\NuGet.ProjectModel.dll                                      694,544
tasks\net9.0\NuGet.Protocol.dll                                        2,058,400
tasks\net9.0\NuGet.Versioning.dll                                        174,352
tasks\net9.0\System.CommandLine.dll                                      354,576
tasks\net9.0\System.Security.Cryptography.Pkcs.dll                       645,384
tasks\net9.0\System.Security.Cryptography.ProtectedData.dll               55,472
tasks\net472\Microsoft.Bcl.AsyncInterfaces.dll                            26,904
tasks\net472\Microsoft.DotNet.Cli.Utils.dll                              109,216
tasks\net472\Microsoft.DotNet.Cli.Utils.dll.config                         1,784
tasks\net472\Microsoft.Extensions.DependencyInjection.Abstractions.dll    64,176
tasks\net472\Microsoft.Extensions.DependencyInjection.dll                 96,944
tasks\net472\Microsoft.Extensions.DependencyModel.dll                     88,336
tasks\net472\Microsoft.Extensions.Logging.Abstractions.dll                68,256
tasks\net472\Microsoft.Extensions.Logging.dll                             54,024
tasks\net472\Microsoft.Extensions.Options.dll                             68,896
tasks\net472\Microsoft.Extensions.Primitives.dll                          49,824
tasks\net472\Microsoft.NET.Build.Containers.deps.json                     32,178
tasks\net472\NuGet.DependencyResolver.Core.dll                           142,368
tasks\net472\NuGet.LibraryModel.dll                                       86,064
tasks\net472\NuGet.ProjectModel.dll                                      327,088
tasks\net472\NuGet.Protocol.dll                                          920,096
tasks\net472\System.Buffers.dll                                           20,856
tasks\net472\System.CommandLine.dll                                      148,528
tasks\net472\System.Diagnostics.DiagnosticSource.dll                     189,192
tasks\net472\System.IO.Pipelines.dll                                      84,232
tasks\net472\System.Memory.dll                                           142,240
tasks\net472\System.Numerics.Vectors.dll                                 115,856
tasks\net472\System.Runtime.CompilerServices.Unsafe.dll                   18,024
tasks\net472\System.Text.Encodings.Web.dll                                79,136
tasks\net472\System.Text.Json.dll                                        668,960
tasks\net472\System.Threading.Tasks.Extensions.dll                        25,984
tasks\net472\System.ValueTuple.dll                                        25,232
tasks\net472\Valleysoft.DockerCredsProvider.dll                           31,280
--------------------------------------------------------------------------------

Drops 4 copies of this ~800KB file from the SDK.

It should never be loaded from this location since the tasks only
make sense in an already running MSBuild.
These files are all in the SDK folder next to MSBuild already and
don't need to be in the task folder.
This is in the SDK/CLI root directory so doesn't need an
additional copy in the .NET Containers directory.
This file isn't used so don't create or ship it.
There was only one real reference, to something that could
could easily be reimplemented to save the on-disk footprint
of Utils.dll.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant