Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize assemblies redistributed in Containers folders #41737

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Minimize assemblies redistributed in Containers folders #41737

wants to merge 7 commits into from

Commits on Jun 20, 2024

  1. Avoid redistributing MSBuild.dll 

    Drops 4 copies of this ~800KB file from the SDK.

It should never be loaded from this location since the tasks only
make sense in an already running MSBuild.
    @rainersigwald
    rainersigwald committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    121f250 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Reduce containers refs redundant with SDK itself 

    These files are all in the SDK folder next to MSBuild already and
don't need to be in the task folder.
    @rainersigwald
    rainersigwald committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b382a9e View commit details
    Browse the repository at this point in the history

  2. Drop Cli.Utils from SDK Containers 

    This is in the SDK/CLI root directory so doesn't need an
additional copy in the .NET Containers directory.
    @rainersigwald
    rainersigwald committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b301acf View commit details
    Browse the repository at this point in the history

  3. Define IsPodmanAlias only when used

    @rainersigwald
    rainersigwald committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ddb98de View commit details
    Browse the repository at this point in the history

  4. Don't force deps file for net472 containers task 

    This file isn't used so don't create or ship it.
    @rainersigwald
    rainersigwald committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d09a4e9 View commit details
    Browse the repository at this point in the history

  5. Decouple net472 containers task from CLI.Utils 

    There was only one real reference, to something that could
could easily be reimplemented to save the on-disk footprint
of Utils.dll.
    @rainersigwald
    rainersigwald committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    00eb996 View commit details
    Browse the repository at this point in the history

  6. Minimize netfx containers task dependencies

    @rainersigwald
    rainersigwald committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8baac23 View commit details
    Browse the repository at this point in the history