Fix Boards Factory - associate with the right project #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR, a Board created via the factory could end up associated with a Node in a different project. We used create(:project) inside the node association which was independent from the board's own :project association. By using an after-build callback we can ensure that the node belongs to the same project already setup via the :project association. We guard this assignment to allow the caller to specify a different node (e.g. a host in the project).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, a Board created via the factory could end up associated with a Node in a different project. We used create(:project) inside the node association which was independent from the board's own :project association.
By using an after-build callback we can ensure that the node belongs to the same project already setup via the :project association.
We guard this assignment to allow the caller to specify a different node (e.g. a host in the project).
Check List
Internal spec refactor, inclined to skip the CHANGELOG.