Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Boards Factory - associate with the right project #1146

Merged
merged 4 commits into from
May 9, 2023
Merged

Fix Boards Factory - associate with the right project #1146

merged 4 commits into from
May 9, 2023

Commits on May 9, 2023

  1. Fix Boards Factory - associate with the right project 

    Before this PR, a Board created via the factory could end up associated
with a Node in a different project. We used create(:project) inside the
node association which was independent from the board's own :project
association.

By using an after-build callback we can ensure that the node belongs to
the same project already setup via the :project association.

We guard this assignment to allow the caller to specify a different node
(e.g. a host in the project).
    @etdsoft
    etdsoft committed May 9, 2023
    Configuration menu
    Copy the full SHA
    2e87033 View commit details
    Browse the repository at this point in the history

  2. Rubocop'ing

    @etdsoft
    etdsoft committed May 9, 2023
    Configuration menu
    Copy the full SHA
    e1e8ef8 View commit details
    Browse the repository at this point in the history

  3. Tweak Card spec

    @etdsoft
    etdsoft committed May 9, 2023
    Configuration menu
    Copy the full SHA
    aed3b9a View commit details
    Browse the repository at this point in the history

  4. More Rubocop :love:

    @etdsoft
    etdsoft committed May 9, 2023
    Configuration menu
    Copy the full SHA
    ce02e85 View commit details
    Browse the repository at this point in the history