chore: connection pipeline cache does not shrink #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
changed the title
kostasrim
commented
Jan 21, 2025
| # pipeline_cache_bytes because it recycled too many messages, they won't gradually be released | ||
| # if one command (one connection out of `n` connections) dispatches async. Only 1 command out of | ||
| # n connections must be dispatched async and the pipeline won't gradually be relesed. | ||
| for i in range(30): |
There was a problem hiding this comment.
We cam drain the pipeline cache bytes once we stop dispatching async. But on large pool of connections only one command must dispatch async and then we need to internally reset the counter. If this pattern continues the size of the cache will remain constant and will not be released gradually.
Signed-off-by: kostas <[email protected]>
kostasrim
commented
Jan 21, 2025
| info = await good_client.info() | ||
|
|
||
| # Drained | ||
| assert info["pipeline_cache_bytes"] == 0 |
There was a problem hiding this comment.
drained completely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test to show that pipeline cache won't shrink once it's filled if clients ping pong between async and sync dispatch
Proves #4461