-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: connection pipeline cache does not shrink #4491
Open
kostasrim
wants to merge
1
commit into
main
Choose a base branch
from
kpr4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1051,3 +1051,60 @@ async def test_hiredis(df_factory): | |
server.start() | ||
client = base_redis.Redis(port=server.port, protocol=3, cache_config=CacheConfig()) | ||
client.ping() | ||
|
||
|
||
@dfly_args({"proactor_threads": 1}) | ||
async def test_pipeline_cache_size(df_factory): | ||
server = df_factory.create(proactor_threads=1) | ||
server.start() | ||
|
||
# Start 1 client. | ||
good_client = server.client() | ||
|
||
await good_client.execute_command("set foo bar") | ||
|
||
bad_actor_client = server.client() | ||
|
||
info = await bad_actor_client.info() | ||
|
||
# Cache is empty. | ||
assert info["pipeline_cache_bytes"] == 0 | ||
assert info["dispatch_queue_bytes"] == 0 | ||
|
||
async def push_pipeline(bad_actor_client): | ||
# Fill cache. | ||
p = bad_actor_client.pipeline(transaction=True) | ||
for i in range(1): | ||
p.lpush(str(i), "V") | ||
await p.execute() | ||
|
||
await push_pipeline(bad_actor_client) | ||
info = await good_client.info() | ||
|
||
old_pipeline_cache_bytes = info["pipeline_cache_bytes"] | ||
assert old_pipeline_cache_bytes > 0 | ||
assert info["dispatch_queue_bytes"] == 0 | ||
|
||
# Whoops, total pipeline_cache_bytes haven't changed. If a workload aggregates a bunch | ||
# pipeline_cache_bytes because it recycled too many messages, they won't gradually be released | ||
# if one command (one connection out of `n` connections) dispatches async. Only 1 command out of | ||
# n connections must be dispatched async and the pipeline won't gradually be relesed. | ||
for i in range(30): | ||
await push_pipeline(bad_actor_client) | ||
await good_client.execute_command(f"set foo{i} bar") | ||
|
||
info = await good_client.info() | ||
|
||
# Pipeline cache bytes remained constant :( | ||
assert old_pipeline_cache_bytes == info["pipeline_cache_bytes"] | ||
assert info["dispatch_queue_bytes"] == 0 | ||
|
||
# Now drain it | ||
for i in range(30): | ||
await good_client.execute_command(f"set foo{i} bar") | ||
|
||
info = await good_client.info() | ||
|
||
# Drained | ||
assert info["pipeline_cache_bytes"] == 0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. drained completely |
||
assert info["dispatch_queue_bytes"] == 0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cam drain the
pipeline cache bytes
once we stop dispatching async. But on large pool of connections only one command must dispatch async and then we need to internally reset the counter. If this pattern continues the size of the cache will remain constant and will not be released gradually.