Conversation
romange
commented
May 3, 2026
- fix action version
- set more options to avoid coincedental overrides of the releases
🤖 Augment PR SummarySummary: Improves the tag-triggered release workflow by pinning 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions release workflow to pin the release-action version and adjust release creation/update behavior to reduce unintended overwrites during tag-based releases.
Changes:
- Pin
ncipollo/release-actiontov1.21.0(instead of@v1) in release creation and publishing steps. - Add release-action options intended to avoid accidental updates/overrides (
skipIfReleaseExists,updateOnlyUnreleased,generateReleaseNotes,commit). - Tighten the
dfly_benchartifact glob todfly_bench-*.tar.gz.
| allowUpdates: true | ||
| draft: true | ||
| updateOnlyUnreleased: true | ||
| skipIfReleaseExists: true |
| omitBody: true | ||
| skipIfReleaseExists: true | ||
| prerelease: true | ||
| draft: true | ||
| generateReleaseNotes: true | ||
| updateOnlyUnreleased: true |
| draft: true | ||
| generateReleaseNotes: true | ||
| updateOnlyUnreleased: true | ||
| commit: ${{ github.sha }} |
There was a problem hiding this comment.
.github/workflows/release.yml:28 — Per the action README, commit is only used when the tag does not exist; since this workflow runs on a tag push, this input may be redundant and could be misleading if the intent was to control the release’s target commitish.
Severity: low
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| artifacts: "artifacts/dragonfly-*/*" | ||
| allowUpdates: true | ||
| draft: true | ||
| updateOnlyUnreleased: true |
There was a problem hiding this comment.
.github/workflows/release.yml:189 — Now that create-release enables generateReleaseNotes, this later allowUpdates run may unintentionally clear the existing release notes body unless the body is explicitly omitted/preserved during updates (e.g., via the action’s omit-body-during-update option).
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
1. fix action version 2. set more options to avoid coincedental overrides of the releases Signed-off-by: Roman Gershman <roman@dragonflydb.io>