Skip to content

chore: release action improvements#7256

Open
romange wants to merge 1 commit intomainfrom
Pr3
Open

chore: release action improvements#7256
romange wants to merge 1 commit intomainfrom
Pr3

Conversation

@romange
Copy link
Copy Markdown
Collaborator

@romange romange commented May 3, 2026

  1. fix action version
  2. set more options to avoid coincedental overrides of the releases

Copilot AI review requested due to automatic review settings May 3, 2026 13:59
@augmentcode
Copy link
Copy Markdown

augmentcode Bot commented May 3, 2026

🤖 Augment PR Summary

Summary: Improves the tag-triggered release workflow by pinning ncipollo/release-action and tightening release update behavior to reduce accidental overwrites.
Changes: Adds safeguards/flags (e.g., skipIfReleaseExists, updateOnlyUnreleased, generateReleaseNotes) and fixes the dfly_bench artifact glob for ARM uploads.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions release workflow to pin the release-action version and adjust release creation/update behavior to reduce unintended overwrites during tag-based releases.

Changes:

  • Pin ncipollo/release-action to v1.21.0 (instead of @v1) in release creation and publishing steps.
  • Add release-action options intended to avoid accidental updates/overrides (skipIfReleaseExists, updateOnlyUnreleased, generateReleaseNotes, commit).
  • Tighten the dfly_bench artifact glob to dfly_bench-*.tar.gz.

allowUpdates: true
draft: true
updateOnlyUnreleased: true
skipIfReleaseExists: true
Comment on lines 22 to +27
omitBody: true
skipIfReleaseExists: true
prerelease: true
draft: true
generateReleaseNotes: true
updateOnlyUnreleased: true
Copy link
Copy Markdown

@augmentcode augmentcode Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

draft: true
generateReleaseNotes: true
updateOnlyUnreleased: true
commit: ${{ github.sha }}
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/release.yml:28 — Per the action README, commit is only used when the tag does not exist; since this workflow runs on a tag push, this input may be redundant and could be misleading if the intent was to control the release’s target commitish.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

artifacts: "artifacts/dragonfly-*/*"
allowUpdates: true
draft: true
updateOnlyUnreleased: true
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/release.yml:189 — Now that create-release enables generateReleaseNotes, this later allowUpdates run may unintentionally clear the existing release notes body unless the body is explicitly omitted/preserved during updates (e.g., via the action’s omit-body-during-update option).

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

1. fix action version
2. set more options to avoid coincedental overrides of the releases

Signed-off-by: Roman Gershman <roman@dragonflydb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants