Skip to content

chore: release action improvements #7256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romange wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −3
Open

chore: release action improvements #7256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Create Release
uses: ncipollo/release-action@v1
uses: ncipollo/release-action@v1.21.0
with:
allowUpdates: true
omitBody: true
skipIfReleaseExists: true
prerelease: true
draft: true
generateReleaseNotes: true
updateOnlyUnreleased: true
Comment on lines 22 to +27
commit: ${{ github.sha }}
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/release.yml:28 — Per the action README, commit is only used when the tag does not exist; since this workflow runs on a tag push, this input may be redundant and could be misleading if the intent was to control the release’s target commitish.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

token: ${{ secrets.GITHUB_TOKEN }}

build-arm:
Expand Down Expand Up @@ -51,7 +55,7 @@ jobs:
path: |
${{ env.RELEASE_DIR }}/dragonfly-*tar.gz
${{ env.RELEASE_DIR }}/dragonfly_*.deb
${{ env.RELEASE_DIR }}/dfly_bench-*tar.gz
${{ env.RELEASE_DIR }}/dfly_bench-*.tar.gz

build-native:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -177,11 +181,13 @@ jobs:
- name: See all the artifacts
run: |
ls -lR artifacts/
- uses: ncipollo/release-action@v1
- uses: ncipollo/release-action@v1.21.0
with:
artifacts: "artifacts/dragonfly-*/*"
allowUpdates: true
draft: true
updateOnlyUnreleased: true
Copy link
Copy Markdown

@augmentcode augmentcode Bot May 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/release.yml:189 — Now that create-release enables generateReleaseNotes, this later allowUpdates run may unintentionally clear the existing release notes body unless the body is explicitly omitted/preserved during updates (e.g., via the action’s omit-body-during-update option).

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

skipIfReleaseExists: true
prerelease: true
omitNameDuringUpdate: true
token: ${{ secrets.GITHUB_TOKEN }}
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,5 @@ tools/replay/traffic-replay
# Valkey-search integration tests (synced from external repo)
tests/dragonfly/valkey_search/integration/
_codeql_build_dir/
# CocoIndex Code (ccc)
/.cocoindex_code/
Loading