[#332] 컨트리뷰터 리팩토링 #333
Merged
[#332] 컨트리뷰터 리팩토링 #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taehwandev
commented
Jun 10, 2024
| val contributors = repository.getContributors( | ||
|
|
||
| operator fun invoke(): Flow<Map<Int, List<Contributor>>> = | ||
| repository.flowContributors( |
There was a problem hiding this comment.
단일 레포지토리라 하나에서 처리하도록 수정
Test Results20 tests 20 ✅ 19s ⏱️ Results for commit 57cb172. ♻️ This comment has been updated with latest results. |
wisemuji
reviewed
Jun 10, 2024
core/data/src/main/java/com/droidknights/app/core/data/api/fake/AssetsGithubRawApi.kt
Show resolved
Hide resolved
.../domain/src/test/java/com/droidknights/app/core/domain/usecase/GetContributorsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
.../domain/src/test/java/com/droidknights/app/core/domain/usecase/GetContributorsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
Comment on lines
8
to
27
| val newList = mutableListOf<ContributorsUiState.Contributors.Item>() | ||
|
|
||
| // key, value 추가 | ||
| forEach { (key, values) -> | ||
| newList.add( | ||
| ContributorsUiState.Contributors.Item.Section( | ||
| title = key.toString(), | ||
| ) | ||
| ) | ||
| values.forEach { item -> | ||
| newList.add( | ||
| ContributorsUiState.Contributors.Item.User( | ||
| id = item.id, | ||
| imageUrl = item.imageUrl, | ||
| githubUrl = item.githubUrl, | ||
| name = item.name, | ||
| ) | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
flatMap을 활용해보면 어떨까요?
Suggested change
| val newList = mutableListOf<ContributorsUiState.Contributors.Item>() | |
| // key, value 추가 | |
| forEach { (key, values) -> | |
| newList.add( | |
| ContributorsUiState.Contributors.Item.Section( | |
| title = key.toString(), | |
| ) | |
| ) | |
| values.forEach { item -> | |
| newList.add( | |
| ContributorsUiState.Contributors.Item.User( | |
| id = item.id, | |
| imageUrl = item.imageUrl, | |
| githubUrl = item.githubUrl, | |
| name = item.name, | |
| ) | |
| ) | |
| } | |
| } | |
| val newList = this.flatMap { (key, values) -> | |
| sequenceOf( | |
| ContributorsUiState.Contributors.Item.Section(title = key.toString()) | |
| ) + values.map { item -> | |
| ContributorsUiState.Contributors.Item.User( | |
| id = item.id, | |
| imageUrl = item.imageUrl, | |
| githubUrl = item.githubUrl, | |
| name = item.name | |
| ) | |
| } | |
| } |
There was a problem hiding this comment.
오 어떻게 할까 고민하다가 한건데 좋은 방법이네요.
| ): List<Contributor> | ||
|
|
||
| suspend fun getContributorsWithYears(): List<ContributorWithYears> | ||
| ): Flow<Map<Int, List<Contributor>>> |
There was a problem hiding this comment.
지금 구조에 이견은 없으나 인터페이스만 보면 해당 데이터가 연도별 컨트리뷰터를 반환할 것이라고 예상되지는 않아서요 🤔 네이밍을 수정하거나 별도의 레퍼 클래스를 만드는 방법도 제안드립니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)