Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#332] 컨트리뷰터 리팩토링 #333

Merged
merged 4 commits into from
Jun 10, 2024
Merged

[#332] 컨트리뷰터 리팩토링 #333

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c838fff
[#332] 컨트리뷰터 리팩토링
taehwandev Jun 10, 2024
24766b0
[#333] 로그 제거
taehwandev Jun 10, 2024
d2676a1
[#333] 코드리뷰 반영
taehwandev Jun 10, 2024
57cb172
[#333] 테스트 코드 오류 수정
taehwandev Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ...-api/src/main/java/com/droidknights/app/core/data/repository/api/ContributorRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
package com.droidknights.app.core.data.repository.api

import com.droidknights.app.core.model.Contributor
import com.droidknights.app.core.model.ContributorWithYears
import kotlinx.coroutines.flow.Flow

interface ContributorRepository {

suspend fun getContributors(
fun flowContributors(
owner: String,
name: String,
): List<Contributor>

suspend fun getContributorsWithYears(): List<ContributorWithYears>
): Flow<Map<Int, List<Contributor>>>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금 구조에 이견은 없으나 인터페이스만 보면 해당 데이터가 연도별 컨트리뷰터를 반환할 것이라고 예상되지는 않아서요 🤔 네이밍을 수정하거나 별도의 레퍼 클래스를 만드는 방법도 제안드립니다.

}
157 changes: 95 additions & 62 deletions core/data/src/main/assets/contributors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,186 +1,219 @@
[
{
"id":28249981,
"name":"laco-dev",
"login": "laco-dev",
"id": 28249981,
"years":[
2023
]
},
{
"id":32327475,
"name":"wisemuji",
"login": "wisemuji",
"id": 32327475,
"years":[
2023,
2024
]
},
{
"id":54518925,
"name":"l2hyunwoo",
"login": "KwakEuiJin",
"id": 93872496,
"years":[
2023
2023,
2024
]
},
{
"id":18674395,
"name":"JeonK1",
"login": "l2hyunwoo",
"id": 54518925,
"years":[
2023
2023,
2024
]
},
{
"id":93872496,
"name":"KwakEuiJin",
"login": "tmdgh1592",
"id": 56534241,
"years":[
2023
2023,
2024
]
},
{
"login": "JeonK1",
"id": 18674395,
"years":[
2023,
2024
]
},
{
"id":57751515,
"name":"yuuuzzzin",
"login": "taehwandev",
"id": 2144231,
"years":[
2023,
2024
]
},
{
"login": "rhkrwngud445",
"id": 33768873,
"years":[
2023,
2024
]
},
{
"login": "yuuuzzzin",
"id": 57751515,
"years":[
2023
]
},
{
"id":53253298,
"name":"toastmeister1",
"login": "toastmeister1",
"id": 53253298,
"years":[
2023
]
},
{
"id":72238126,
"name":"yjyoon-dev",
"login": "Cjsghkd",
"id": 84944098,
"years":[
2023
]
},
{
"id":84944098,
"name":"Cjsghkd",
"login": "yjyoon-dev",
"id": 72238126,
"years":[
2023
]
},
{
"id":22849063,
"name":"KimReady",
"login": "HamBP",
"id": 35232655,
"years":[
2024
]
},
{
"id":2144231,
"name":"taehwandev",
"login": "chattymin",
"id": 52882799,
"years":[
2023,
2024
]
},
{
"id":37904970,
"name":"sodp5",
"login": "KimReady",
"id": 22849063,
"years":[
2023
2024
]
},
{
"id":51078673,
"name":"JaesungLeee",
"login": "ParkJong-Hun",
"id": 81838716,
"years":[
2023
2024
]
},
{
"id":61337202,
"name":"koreatlwls",
"login": "koreatlwls",
"id": 61337202,
"years":[
2023
]
},
{
"id":44341119,
"name":"malibinYun",
"login": "sodp5",
"id": 37904970,
"years":[
2023
]
},
{
"id":1534926,
"name":"Pluu",
"login": "JaesungLeee",
"id": 51078673,
"years":[
2023
]
},
{
"id":81838716,
"name":"ParkJong-Hun",
"login": "malibinYun",
"id": 44341119,
"years":[
2024
2023
]
},
{
"id":92064758,
"name":"theo-taehwan",
"login": "taeheeL",
"id": 98825364,
"years":[
2024
2023
]
},
{
"id":52663419,
"name":"jeongth9446",
"login": "Pluu",
"id": 1534926,
"years":[
2023
]
},
{
"id":4679634,
"name":"kisa002",
"login": "kisa002",
"id": 4679634,
"years":[
2023
]
},
{
"id":40175383,
"name":"gowoon-choi",
"login": "jeongth9446",
"id": 52663419,
"years":[
2023
]
},
{
"id":7759511,
"name":"workspace",
"login": "theo-taehwan",
"id": 92064758,
"years":[
2024
]
},
{
"login": "gowoon-choi",
"id": 40175383,
"years":[
2023
]
},
{
"id":51016231,
"name":"easyhooon",
"login": "easyhooon",
"id": 51016231,
"years":[
2024
]
},
{
"id":33443660,
"name":"KwonDae",
"login": "workspace",
"id": 7759511,
"years":[
2023
]
},
{
"id":35232655,
"name":"HamBP",
"login": "KwonDae",
"id": 33443660,
"years":[
2024
2023
]
},
{
"id":76798309,
"name":"onseok",
"login": "onseok",
"id": 76798309,
"years":[
2023
]
}
]
]
Loading
Loading