Skip to content

[codex] Address epoch gaincal test review#24

Merged
jakobtfaber merged 1 commit into
mainfrom
codex/pr14-review-test-cleanup
Apr 30, 2026
Merged

[codex] Address epoch gaincal test review#24
jakobtfaber merged 1 commit into
mainfrom
codex/pr14-review-test-cleanup

Conversation

@jakobtfaber
Copy link
Copy Markdown
Contributor

Summary

Review context

Addresses the unresolved Copilot review thread from PR #14 on tests/test_epoch_gaincal_field_shape.py. The modulo was already applied after converting to degrees in the merged code, but the exact equality feedback was valid and the rewrite makes the expectation clearer.

Validation

  • PYTHONPATH=/workspace python3 -m pytest tests/test_epoch_gaincal_field_shape.py -q
  • ruff check tests/test_epoch_gaincal_field_shape.py
  • ruff format --check tests/test_epoch_gaincal_field_shape.py
  • git diff --check -- tests/test_epoch_gaincal_field_shape.py

Copilot AI review requested due to automatic review settings April 30, 2026 05:30
@jakobtfaber jakobtfaber merged commit e888523 into main Apr 30, 2026
3 checks passed
@jakobtfaber jakobtfaber deleted the codex/pr14-review-test-cleanup branch April 30, 2026 05:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the epoch gaincal FIELD-shape regression tests to be numerically robust and clearer about the expected RA computation, addressing prior review feedback from PR #14.

Changes:

  • Replace exact RA float equality with np.testing.assert_allclose.
  • Compute expected_ra explicitly before asserting, improving readability.
  • Apply ruff format-normalized formatting to the touched test arrays/expressions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants