[codex] Address epoch gaincal test review#24
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the epoch gaincal FIELD-shape regression tests to be numerically robust and clearer about the expected RA computation, addressing prior review feedback from PR #14.
Changes:
- Replace exact RA float equality with
np.testing.assert_allclose. - Compute
expected_raexplicitly before asserting, improving readability. - Apply
ruff format-normalized formatting to the touched test arrays/expressions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
np.testing.assert_allcloseruff formatnormalize the touched test fileReview context
Addresses the unresolved Copilot review thread from PR #14 on
tests/test_epoch_gaincal_field_shape.py. The modulo was already applied after converting to degrees in the merged code, but the exact equality feedback was valid and the rewrite makes the expectation clearer.Validation
PYTHONPATH=/workspace python3 -m pytest tests/test_epoch_gaincal_field_shape.py -qruff check tests/test_epoch_gaincal_field_shape.pyruff format --check tests/test_epoch_gaincal_field_shape.pygit diff --check -- tests/test_epoch_gaincal_field_shape.py