Skip to content

[codex] Address epoch gaincal test review #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobtfaber merged 1 commit into from
Apr 30, 2026
Merged

[codex] Address epoch gaincal test review #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 23 additions & 19 deletions tests/test_epoch_gaincal_field_shape.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ def _make_fake_table(phase_dir: np.ndarray):
Mirrors the mock pattern in tests/test_skymodel_phase_dir.py — cloud-safe,
no real CASA needed.
"""

class FakeTable:
def __init__(self, path, *_, **__):
self.path = path
Expand All @@ -48,15 +49,18 @@ def test_read_ms_phase_center_rows_first_shape(monkeypatch):
from dsa110_continuum.adapters import casa_tables
from dsa110_continuum.calibration import epoch_gaincal

phase_dir = np.array([
[[np.radians(180.0), np.radians(22.0)]],
[[np.radians(181.0), np.radians(22.5)]],
]) # shape (2, 1, 2)
phase_dir = np.array(
[
[[np.radians(180.0), np.radians(22.0)]],
[[np.radians(181.0), np.radians(22.5)]],
]
) # shape (2, 1, 2)
monkeypatch.setattr(casa_tables, "table", _make_fake_table(phase_dir))

ra_deg, dec_deg = epoch_gaincal._read_ms_phase_center("/fake/ms")

assert ra_deg == np.degrees(np.angle(np.mean(np.exp(1j * np.radians([180.0, 181.0]))))) % 360
expected_ra = np.degrees(np.angle(np.mean(np.exp(1j * np.radians([180.0, 181.0]))))) % 360
np.testing.assert_allclose(ra_deg, expected_ra)
np.testing.assert_allclose(dec_deg, np.degrees(np.median([np.radians(22.0), np.radians(22.5)])))


Expand All @@ -70,18 +74,18 @@ def test_read_ms_phase_center_casa_column_major_shape(monkeypatch):
from dsa110_continuum.adapters import casa_tables
from dsa110_continuum.calibration import epoch_gaincal

phase_dir = np.array([
[[np.radians(180.0)], [np.radians(22.0)]],
[[np.radians(181.0)], [np.radians(22.5)]],
]) # shape (2, 2, 1)
phase_dir = np.array(
[
[[np.radians(180.0)], [np.radians(22.0)]],
[[np.radians(181.0)], [np.radians(22.5)]],
]
) # shape (2, 2, 1)
monkeypatch.setattr(casa_tables, "table", _make_fake_table(phase_dir))

# Pre-fix this raised IndexError. Post-fix it returns plausible values.
ra_deg, dec_deg = epoch_gaincal._read_ms_phase_center("/fake/ms")

expected_ra = np.degrees(
np.angle(np.mean(np.exp(1j * np.radians([180.0, 181.0]))))
) % 360
expected_ra = np.degrees(np.angle(np.mean(np.exp(1j * np.radians([180.0, 181.0]))))) % 360
np.testing.assert_allclose(ra_deg, expected_ra)
np.testing.assert_allclose(dec_deg, np.degrees(np.median([np.radians(22.0), np.radians(22.5)])))

Expand All @@ -91,17 +95,17 @@ def test_read_ms_phase_center_2d_fallback_shape(monkeypatch):
from dsa110_continuum.adapters import casa_tables
from dsa110_continuum.calibration import epoch_gaincal

phase_dir = np.array([
[np.radians(180.0), np.radians(22.0)],
[np.radians(181.0), np.radians(22.5)],
]) # shape (2, 2)
phase_dir = np.array(
[
[np.radians(180.0), np.radians(22.0)],
[np.radians(181.0), np.radians(22.5)],
]
) # shape (2, 2)
monkeypatch.setattr(casa_tables, "table", _make_fake_table(phase_dir))

ra_deg, dec_deg = epoch_gaincal._read_ms_phase_center("/fake/ms")

expected_ra = np.degrees(
np.angle(np.mean(np.exp(1j * np.radians([180.0, 181.0]))))
) % 360
expected_ra = np.degrees(np.angle(np.mean(np.exp(1j * np.radians([180.0, 181.0]))))) % 360
np.testing.assert_allclose(ra_deg, expected_ra)
np.testing.assert_allclose(dec_deg, np.degrees(np.median([np.radians(22.0), np.radians(22.5)])))

Expand Down
Loading