-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add following through wormholes support #16
Conversation
I was thinking about pausing the follow thread while a seperate thread(The wormhole travel thread) does its thing, however, there is no pause functionality. As such, I had to just to leave it in a state of looping and checking. |
Ideally, we should change the behaviour of the current threads from less direct usage to the corresponding functionality in entities themselves, like entity tasks as Klei have originally intended. But at some point, I've just decided to leave everything as-is for some reason. When it comes to your solution, I think everything should be fine if it works. I'll check later as soon as I will overcome my unwillingness to open the game. |
464946f
to
a72dcfd
Compare
Force-pushed to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've mentioned in Slack about the "nitpicks" and have asked me to comment. So I saw this as a sign that you want to try fixing everything yourself, so I'll just review instead.
The only thing I've done: rebase to the latest develop
, so that you could've CI to assist you. I've also resolved all the conflicts by just accepting your variant. Keep in mind, that your variant is outdated, as it doesn't include the merged #8.
When it comes to the business logic, I didn't test this feature yet, and I believe you are more qualified in this aspect than I am since you are the one who is implementing it. I trust you, so use whatever approach you think fits best.
0095596
to
0d12ded
Compare
Force-pushed to squash several commits, which are doing the same thing: fixing StyLua and Luacheck issues. |
Add a stale reference handler for the wormhole travel thread.
Add debug RPC counter for jumping through the wormhole for consistency.
93b3a2c
to
7f79f87
Compare
Force-pushed to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Everything works from my side. Have tested on dedicated server with 2 real players.
Closes #3.