Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide support #8

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Add hide support #8

merged 1 commit into from
Nov 11, 2021

Conversation

ViktorYu234
Copy link
Member

@ViktorYu234 ViktorYu234 commented Oct 25, 2021

Partly solves #1 and #2.

Player automatically hides if he/she has a "Bush Hat" or "Snurtle Shell Armor" equipped while following.

Copy link
Member

@victorpopkov victorpopkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: It doesn't matter, but the branch name points to the wrong issue. In our case, it's a very unlikely scenario to get confused when there are so few branches. Moreover, if a branch points to multiple issues, it's better to not use the reference ID as part of the name and just use the default naming approach. In this case, for example: ViktorYu234/feature/hide-support.

scripts/components/keepfollowing.lua Outdated Show resolved Hide resolved
@victorpopkov victorpopkov added enhancement New feature or request Hacktoberfest Hacktoberfest 2021 labels Oct 26, 2021
@victorpopkov
Copy link
Member

Feel free to ping me (just @mention me in the comments) if you need any help. You don't need to open another PR. Just commit and push the changes into this branch. I would suggest you to experiment with Git commits squashing here as well.

Or you may just leave everything as is, and I'll fix everything later before merging.

The player now automatically hides if he/she has a "Bush Hat" or
"Snurtle Shell Armor" equipped while following someone.
@victorpopkov victorpopkov merged commit 392391f into develop Nov 11, 2021
@victorpopkov victorpopkov deleted the ViktorYu234/issue-1 branch November 11, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest Hacktoberfest 2021
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Snurtle Shell Armor auto-hide support Add Bush Hat auto-hide support
2 participants