Skip to content

Set MSRV 1.85 & set stable toolchain#273

Merged
HDauven merged 1 commit intomasterfrom
msrv-stable
Feb 2, 2026
Merged

Set MSRV 1.85 & set stable toolchain#273
HDauven merged 1 commit intomasterfrom
msrv-stable

Conversation

@HDauven
Copy link
Member

@HDauven HDauven commented Jan 24, 2026

Resolves #274

@HDauven HDauven requested a review from Copilot January 24, 2026 15:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Rust toolchain from a nightly version to stable and sets the MSRV to 1.85, while making minor code improvements including removing unnecessary type conversions and optimizing loop calculations.

Changes:

  • Updated Rust toolchain from nightly-2023-11-10 to stable channel
  • Set minimum supported Rust version (MSRV) to 1.85 in Cargo.toml
  • Optimized permutation loop logic to avoid redundant calculations

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Added rust-version field specifying MSRV 1.85
rust-toolchain.toml Changed toolchain channel from nightly to stable
rustfmt.toml Removed wrap_comments configuration option
src/hades/permutation.rs Refactored loop bounds to pre-calculate values and simplify iteration
src/hades/permutation/scalar.rs Removed redundant as_ref() call on input parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@HDauven
Copy link
Member Author

HDauven commented Jan 25, 2026

Blocked by: dusk-network/plonk#857

Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good except the changes to the hades permutation

@HDauven
Copy link
Member Author

HDauven commented Feb 2, 2026

all good except the changes to the hades permutation

Reverted the changes as requested. There was a clippy warning before in ROUNDS that's no longer there. (or maybe I'm hallucinating)

Only changes now are related to formatting & edition/msrv changes.

@HDauven HDauven requested a review from moCello February 2, 2026 11:07
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HDauven HDauven merged commit 278ac11 into master Feb 2, 2026
6 checks passed
@moCello moCello deleted the msrv-stable branch February 2, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set MSRV 1.85, switch to stable toolchain and upgrade to edition 2024

2 participants