Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust toolchain from a nightly version to stable and sets the MSRV to 1.85, while making minor code improvements including removing unnecessary type conversions and optimizing loop calculations.
Changes:
- Updated Rust toolchain from nightly-2023-11-10 to stable channel
- Set minimum supported Rust version (MSRV) to 1.85 in Cargo.toml
- Optimized permutation loop logic to avoid redundant calculations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Added rust-version field specifying MSRV 1.85 |
| rust-toolchain.toml | Changed toolchain channel from nightly to stable |
| rustfmt.toml | Removed wrap_comments configuration option |
| src/hades/permutation.rs | Refactored loop bounds to pre-calculate values and simplify iteration |
| src/hades/permutation/scalar.rs | Removed redundant as_ref() call on input parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Blocked by: dusk-network/plonk#857 |
4a718e2 to
8f5b7e8
Compare
moCello
left a comment
There was a problem hiding this comment.
all good except the changes to the hades permutation
Reverted the changes as requested. There was a clippy warning before in Only changes now are related to formatting & edition/msrv changes. |
Resolves #274