Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): synonymize "open" and "connect to" #29

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

denizenging
Copy link
Member

Now, "open" and "connect to" are synonyms. Added two new method signature to PluginContext as well, getOpen() and fetchOpen(), which are synonyms to getOpen() and fetchOpen() too.

Now, "open" and "connect to" are synonyms.  Added two new method signature to
PluginContext as well, getOpen() and fetchOpen(), which are synonyms to
getOpen() and fetchOpen() too.
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (db4ce55) 96.44% compared to head (32f99d8) 95.87%.
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   96.44%   95.87%   -0.57%     
==========================================
  Files          21       21              
  Lines        1041     1092      +51     
  Branches       90       94       +4     
==========================================
+ Hits         1004     1047      +43     
- Misses         36       44       +8     
  Partials        1        1              
Files Coverage Δ
pkg/core/src/parser.ts 100.00% <100.00%> (ø)
pkg/core/src/tokens.ts 100.00% <100.00%> (ø)
pkg/core/src/visitor.ts 100.00% <100.00%> (ø)
pkg/http/src/parser.ts 100.00% <100.00%> (ø)
pkg/core/src/plugin.ts 92.70% <83.87%> (-1.61%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I thought it is nicer since we also have getOpen() and getConnect() (and fetch*
variants).
@denizenging denizenging merged commit 1ad444e into main Oct 17, 2023
4 of 6 checks passed
@denizenging denizenging deleted the sf/openconnect branch October 17, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant