Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): synonymize "open" and "connect to" #29

Merged
merged 2 commits into from
Oct 17, 2023
Merged

feat(core): synonymize "open" and "connect to" #29

merged 2 commits into from
Oct 17, 2023

Commits on Oct 13, 2023

  1. feat(core): synonymize "open" and "connect to" 

    Now, "open" and "connect to" are synonyms.  Added two new method signature to
PluginContext as well, getOpen() and fetchOpen(), which are synonyms to
getOpen() and fetchOpen() too.
    @denizenging
    denizenging committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    b822da6 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. feat(core): separate open() and connect() constructors 

    I thought it is nicer since we also have getOpen() and getConnect() (and fetch*
variants).
    @denizenging
    denizenging committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    32f99d8 View commit details
    Browse the repository at this point in the history