Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations severe update #486

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Translations severe update #486

merged 4 commits into from
Aug 24, 2023

Conversation

nerun
Copy link
Contributor

@nerun nerun commented Jun 27, 2023

Where to start from?

1) Translations: updated 'es', 'fr', 'it' and 'ru.po' to line up help message (PR #481 and Jaromil request in PR #483).

One request before merging, which should be easy to do: can you please also update the .po translations with this detail? so we keep them aligned.

Done. I used a script to print help output out of PO files and check all them:

#!/usr/bin/env zsh
clear
egrep -A 141 'Syntax:' $1 | 
egrep -v "^(#|msgid|\s*$)" | 
sed 's/msgstr \"//g' | 
sed 's/\" / /g' | 
grep -v "^\"" |
sed 's/\"$//g'

Not important, just saying.

2) Updated Brazilian Portuguese translation (pt_BR). Also updated Makefile to include this translation.

Related to issue #482. I have translated to pt_BR before Weblate was created, sorry. But thank you for that.

3) Added Brazilian Portuguese (pt_BR) translation (for Tomb 2.10). Also created tomb.pot template for version 2.10.

Hard to explain, better to read the ne created README for extras/translations folder. It's all very well explained there.

4) Created a README file in extras/translations to clear up confused issues about translations versions.

This is a huge point, ALL translations in extras/translations are based upon Tomb 2.3, not the current 2.10 or the stable 2.9. I think i have explained it very well in README. Please read it.

@nerun
Copy link
Contributor Author

nerun commented Jun 29, 2023

You can see the README file, in my fork right here.

@nerun
Copy link
Contributor Author

nerun commented Jul 3, 2023

@jaromil , can you take a look in this PR? I can split it in different commits if needed.

@jaromil
Copy link
Member

jaromil commented Aug 24, 2023

This looks very well done. Thanks for the README!

@jaromil jaromil merged commit 58035cf into dyne:master Aug 24, 2023
2 checks passed
@nerun nerun deleted the translations branch August 24, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants