Extend storage stats calculation to include virtual and inline chunks #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chunks (double-counting virtual chunks that don't have checksums)
… length) tuple if checksum not available
TomNicholas
commented
Dec 12, 2025
icechunk/src/ops/stats.rs
Outdated
Comment on lines
122
to
129
| checksum.clone(), | ||
| virtual_ref.length, | ||
| &mut virtual_bytes, | ||
| )?; | ||
| } else { | ||
| // No checksum: deduplicate by (location, offset, length) | ||
| let virtual_identifier = ( | ||
| virtual_ref.location.clone(), |
Member
Author
There was a problem hiding this comment.
FYI I think it's possible to remove these clones (by passing a reference and then only actually cloning if needed), but it comes at the cost of an additional if. Maybe worth it though to minimize memory usage?
Member
Author
There was a problem hiding this comment.
I just left a todo for this. It might be worthwhile to run it on a really big virtual repo before merging just to see what the memory usage is like.
paraseba
reviewed
Dec 12, 2025
Member
Author
|
I added some tests, including of virtual chunk deduplication. |
TomNicholas
commented
Dec 13, 2025
| }) | ||
| } | ||
|
|
||
| pub(crate) fn total_chunks_storage( |
Member
Author
There was a problem hiding this comment.
I didn't bother trying to do a deprecation cycle in the rust crate.
paraseba
reviewed
Dec 17, 2025
| DeprecationWarning, | ||
| ) | ||
|
|
||
| stats = await self._repository.chunk_storage_stats( |
Collaborator
There was a problem hiding this comment.
I think we need to call the _async version here?
| } | ||
|
|
||
| pub(crate) fn total_chunks_storage( | ||
| pub(crate) fn chunk_storage_stats( |
Collaborator
There was a problem hiding this comment.
I think you are missing to mirror this change in the .pyi file.
…r/icechunk into virtual-storage-stats
paraseba
approved these changes
Dec 18, 2025
TomNicholas
added a commit
that referenced
this pull request
Dec 29, 2025
…#1483) * define rust struct * expose struct in python * add python docstrings * extend repo_chunks_storage calculation to include virtual and native chunks (double-counting virtual chunks that don't have checksums) * fully deduplicate virtual chunks when counting by using (url, offset, length) tuple if checksum not available * factor out helper function * compile icechunk-python * rewire existing python method to use new method * add async method * update outdated comment * add python deprecation warnings * restrict to pub(crate) * correct bug in calculation of non-virtual bytes * only use (location, offset, length) as an identifier fo de-duplicating virtual chunks * add todo comment about cloning * use the inner pattern to wrap the rust-only struct inside the python-exposed one * correct name of python class * expose __add__ method in python * cargo formatting for python crate too * rust tests * correct python return type * actually correct python return type * call async method in python * update .pyi file with new methods * python linting * explicitly specify stacklevel for warning * expect warnings in tests
TomNicholas
added a commit
that referenced
this pull request
Jan 2, 2026
* Extend storage stats calculation to include virtual and inline chunks (#1483) * define rust struct * expose struct in python * add python docstrings * extend repo_chunks_storage calculation to include virtual and native chunks (double-counting virtual chunks that don't have checksums) * fully deduplicate virtual chunks when counting by using (url, offset, length) tuple if checksum not available * factor out helper function * compile icechunk-python * rewire existing python method to use new method * add async method * update outdated comment * add python deprecation warnings * restrict to pub(crate) * correct bug in calculation of non-virtual bytes * only use (location, offset, length) as an identifier fo de-duplicating virtual chunks * add todo comment about cloning * use the inner pattern to wrap the rust-only struct inside the python-exposed one * correct name of python class * expose __add__ method in python * cargo formatting for python crate too * rust tests * correct python return type * actually correct python return type * call async method in python * update .pyi file with new methods * python linting * explicitly specify stacklevel for warning * expect warnings in tests * resolve merge conflicts properly * more merge fixes * more merge fixes * update paths for bundled test repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1478.
Compiles (at least the core rust crate does), but I haven't tested it yet.
EDIT: Ready