Skip to content

Add chunk container repr, fix test dataset #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcherian merged 1 commit into from
Apr 3, 2025
Merged

Add chunk container repr, fix test dataset #893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions icechunk-python/tests/data/test-repo/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,5 @@ virtual_chunk_containers:
endpoint_url: http://localhost:9000
anonymous: false
allow_http: true
force_path_style: true
manifest: null
31 changes: 16 additions & 15 deletions icechunk-python/tests/test_can_read_old.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,23 @@
import zarr


def mk_repo(create: bool) -> ic.Repository:
def mk_repo(*, create: bool, config: ic.RepositoryConfig | None = None) -> ic.Repository:
"""Create a store that can access virtual chunks in localhost MinIO"""
store_path = "./tests/data/test-repo"

config = ic.RepositoryConfig.default()
config.inline_chunk_threshold_bytes = 12

virtual_store_config = ic.s3_store(
region="us-east-1",
endpoint_url="http://localhost:9000",
allow_http=True,
s3_compatible=True,
force_path_style=True,
)
container = ic.VirtualChunkContainer("s3", "s3://", virtual_store_config)
config.set_virtual_chunk_container(container)
if create and config is None:
config = ic.RepositoryConfig.default()
config.inline_chunk_threshold_bytes = 12

virtual_store_config = ic.s3_store(
region="us-east-1",
endpoint_url="http://localhost:9000",
allow_http=True,
s3_compatible=True,
force_path_style=True,
)
container = ic.VirtualChunkContainer("s3", "s3://", virtual_store_config)
config.set_virtual_chunk_container(container)
credentials = ic.containers_credentials(
s3=ic.s3_credentials(access_key_id="minio123", secret_access_key="minio123")
)
Expand All @@ -62,7 +63,7 @@ async def write_a_test_repo() -> None:
"""

print("Writing repository to ./tests/data/test-repo")
repo = mk_repo(True)
repo = mk_repo(create=True)
session = repo.writable_session("main")
store = session.store

Expand Down Expand Up @@ -168,7 +169,7 @@ async def test_icechunk_can_read_old_repo() -> None:
# we import here so it works when the script is ran by pytest
from tests.conftest import write_chunks_to_minio

repo = mk_repo(False)
repo = mk_repo(create=False)
main_snapshot = repo.lookup_branch("main")

expected_main_history = [
Expand Down