Runtime-Based MicroProfile Config Validation for LSP4MP

[angelozerr]

Runtime-Based MicroProfile Config Validation for LSP4MP

Fixes #511

Here a sample in application.properties which report error by using SamllRye converter:

and in Java files:

it is working also with custom enum:

The settings "microprofile.tools.validation.value.severity": "none|error|warning" is now used to manage validation value error: in properties and Java files:

[datho7561]

I'll keep looking tomorrow, I'm still trying to understand the code.

[fbricon]

Can't we provide an extension point instead for eg. Liberty tools to provide their Validation mechanism, and just disable value validation if none is provided?

There are several things I'm not comfortable with:

• storing jars in a git repo, when they could be downloaded at build time
• hardcoding jar names+ arbitrary versions in the code

[angelozerr]

Can't we provide an extension point instead for eg. Liberty tools to provide their Validation mechanism, and just disable value validation if none is provided?

It is not only for Liberty Tools, it is for other MP project which have no MP implementation in their classpath.

We could indeed providing an extension point for that, but I am not sure that it is really interesting. This PR has been tested with Quarkus/Liberty project on all OS and it seems it is working pretty well.

I would like to merge this PR and work on evaluate mode like I have explained in #511 (comment)

There are several things I'm not comfortable with:

• storing jars in a git repo, when they could be downloaded at build time
• hardcoding jar names+ arbitrary versions in the code

I agree but can I merge the PR and improve that after the merge. @datho7561 do you think you could work on it?

I would like really working on evaluate mode like I have explained in #511 (comment) because I want to fix (fixed on IJ Quarkus) a lof of false positive erros with property key/values that we have and reported in IJ Quarkus, vscode-quarkus, vscode-microprofile

But for now I need this PR and next PR with evaluate mode to include it in IJ Quarkus which will fix a lot of false positive errors.

[angelozerr]

IBM are OK to merge this PR, @datho7561 @fbricon are OK with that?

[angelozerr]

There are several things I'm not comfortable with:

• storing jars in a git repo, when they could be downloaded at build time

fixed (thanks to @datho7561 )

hardcoding jar names+ arbitrary versions in the code

Now the strategy is different, MicroProfile JDT add those lib in the Bundle CLasspath. I need to do that because SmallRye Config is complex (not OSGIfied and use Java SPI). I spent so many times to try to support this SmallRyeConfig dependency with tycho (like we have with SmallRye expression but without success).

[angelozerr]

See PR redhat-developer/vscode-microprofile#546 which defines "microprofile.tools.execution.mode" (safe, full)

[angelozerr]

Since IBM has tested the PR with Liberty and me I have tested with Quarkus/Liberty I merged the PR because I would like to integrate thi sfeature in IJ Quarkus which is very expected by user.

If there are some improvement to do in this PR, don't hesitate to create issues.