fix memory leak in z_declare_subscriber #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cguimaraes
reviewed
Oct 12, 2023
|
Although not necessary to fix the memory leak issue, this is one of the few places where the result of Thank you very much for the fix. |
cguimaraes
approved these changes
Oct 12, 2023
cguimaraes
requested changes
Oct 13, 2023
src/api/api.c
Outdated
| suffix[len] = 0; | ||
| keyexpr._suffix = suffix; | ||
| _z_keyexpr_set_owns_suffix(&keyexpr, false); | ||
| } | ||
| } | ||
| uint16_t id = _z_declare_resource(zs._val, keyexpr); |
There was a problem hiding this comment.
What is declared if suffix allocation fails? It seems that it will declare a keyexpr with id but no suffix...
There was a problem hiding this comment.
It will declare the exact keyexpr that was passed to the subscriber, but will keep the wild suffix, so the bug is not the one you expected, but it is buggy
There was a problem hiding this comment.
Actually was a bug, but not the one you expected. Let's just cancel attempting to declare the resource if we failed to allocate for the suffix, the other steps would probably also fail anyway.
cguimaraes
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #259