Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI improvements #273

Merged
merged 21 commits into from
Nov 9, 2023
Merged

CI improvements #273

merged 21 commits into from
Nov 9, 2023

Conversation

jean-roland
Copy link
Contributor

@jean-roland jean-roland commented Nov 6, 2023 •
edited
Loading

While adding the modularity test in #268 I noticed some axis of improvements for the CI:

  • Added more warning flags on gcc to make errors more consistent with MSVC
  • Subsequent warning fixes
  • A lot of missing end of file line feed
  • Run unit tests in CI, that would have helped detecting fix misencoding of query body #265 & Keep tests assert in release build #266 earlier
  • Run format check in CI
  • Subsequent format fix
  • Modular tests use ninja instead of make to speed things up
  • Removed some pylint warnings on modularity test
  • Updated the github actions checkout directive

cguimaraes
cguimaraes approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@cguimaraes cguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just small comments.

examples/arduino/z_sub.ino Show resolved Hide resolved
examples/unix/c11/z_get.c Show resolved Hide resolved
examples/unix/c11/z_pull.c Show resolved Hide resolved
examples/unix/c11/z_queryable.c Show resolved Hide resolved
examples/unix/c11/z_sub.c Show resolved Hide resolved
examples/unix/c99/z_pong.c Show resolved Hide resolved
@jean-roland jean-roland mentioned this pull request Nov 9, 2023
Closed
@Mallets Mallets merged commit d86ad8d into eclipse-zenoh:master Nov 9, 2023
46 checks passed
@jean-roland jean-roland deleted the ft_improve_ci branch November 10, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mallets Mallets Mallets approved these changes

@cguimaraes cguimaraes cguimaraes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jean-roland @cguimaraes @Mallets