Add AddressSanitizer to CI tests #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'documentation', 'dependencies', 'new feature', 'internal', 'breaking-change', 'enhancement', 'bug'} |
sashacmc
force-pushed
the
asan_ci_tests
branch
3 times, most recently
from
89b9505 to
39ea2b0
Compare
sashacmc
force-pushed
the
asan_ci_tests
branch
from
39ea2b0 to
7c96d1b
Compare
sashacmc
force-pushed
the
asan_ci_tests
branch
from
a91ce1b to
5f3499d
Compare
sashacmc
force-pushed
the
asan_ci_tests
branch
from
5f3499d to
b64706a
Compare
jean-roland
approved these changes
Nov 23, 2024
| @@ -453,6 +454,11 @@ if(BUILD_EXAMPLES) | |||
| add_subdirectory(examples) | |||
| endif() | |||
|
|
|||
| if(ASAN) | |||
| add_compile_options(-fsanitize=address) | |||
There was a problem hiding this comment.
this is not correct, since -fsanitize is a clang/gcc feature only and thus will fail with other compilers (for example for MSVC it is /fsanitize=address)
There was a problem hiding this comment.
I didn't tested it with MSVC, but as far as I see there
https://learn.microsoft.com/en-us/cpp/build/reference/compiler-options?view=msvc-170
and there
https://learn.microsoft.com/en-us/cpp/sanitizers/asan?view=msvc-170
this type of option is also correct.
In addition, this is an optional option that does not have to be enabled for all compilers.
DenisBiryukov91
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AddressSanitizer to CI tests and fix memory issues:
Closes: #801