Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null allocation in msgcodec #905

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Fix null allocation in msgcodec #905

merged 2 commits into from
Feb 28, 2025

Conversation

jean-roland
Copy link
Contributor

  • Unit tests were not run as DEBUG on CI.
  • When run as DEBUG, issues related to the null allocation change (Fix 0 size allocation #877) appeared and are fixed with this PR.

@jean-roland jean-roland added the bug Something isn't working label Feb 28, 2025
gmartin82
gmartin82 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@gmartin82 gmartin82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Fixes the test failure and ensures tests are run in debug mode through the CI which means assert's in the main codebase will be triggered if violated.

@gabrik gabrik merged commit da81fbd into eclipse-zenoh:main Feb 28, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmartin82 gmartin82 gmartin82 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jean-roland @gmartin82 @gabrik