Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add musl build support #29

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

rongfengliang
Copy link
Contributor

add musl build support

Copy link

PR missing one of the required labels: {'documentation', 'enhancement', 'new feature', 'breaking-change', 'bug', 'internal', 'dependencies'}

@rongfengliang rongfengliang mentioned this pull request Nov 10, 2024
@diogomatsubara
Copy link
Contributor

diogomatsubara commented Nov 13, 2024

Hi @rongfengliang , thanks for your contribution! We require all contributors to sign the Eclipse Contributor Agreement. Could you have it signed so we can consider this PR? Details on how to sign it can be found here: https://api.eclipse.org/git/eca/status/gh/eclipse-zenoh/zenoh-ts/29

@diogomatsubara diogomatsubara added the internal Changes not included in the changelog label Nov 13, 2024
@diogomatsubara
Copy link
Contributor

@rongfengliang Also take a look at https://github.com/eclipse-zenoh/zenoh-ts/actions/runs/11720545273/job/32646150245#step:2:406, last time we tried to build for those musl targets we got this error and I'm not sure if the addition of the .cargo/config.toml will make a difference.

@rongfengliang
Copy link
Contributor Author

@diogomatsubara I had do some tests with this config, also this config is the same as other zenoh sub project config
https://github.com/eclipse-zenoh/zenoh-backend-filesystem/blob/main/.cargo/config.toml

@Mallets Mallets changed the base branch from main to add-musl-build November 14, 2024 12:51
@Mallets Mallets changed the base branch from add-musl-build to main November 14, 2024 13:00
Mallets added a commit that referenced this pull request Nov 14, 2024
@diogomatsubara
Copy link
Contributor

Changes proposed tested here: https://github.com/eclipse-zenoh/zenoh-ts/actions/runs/11839108359/job/32989870069 and they work to build the musl targets. LGTM

@diogomatsubara diogomatsubara self-requested a review November 14, 2024 14:37
@Mallets Mallets merged commit 82758ed into eclipse-zenoh:main Nov 14, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes not included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants