Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS API code review Fixes #5

Merged
merged 11 commits into from
Oct 29, 2024
Merged

TS API code review Fixes #5

merged 11 commits into from
Oct 29, 2024

Conversation

Charles-Schleich
Copy link
Member

@Charles-Schleich Charles-Schleich commented Oct 24, 2024 •
edited
Loading

Implemented:

  • Use of JS constructors instead of static new functions
  • replaced @hidden with @ignore for doc generation
  • Hidden creation of subscriber with Symbol NewSubscriber
  • Renamed Opts -> Options
  • Added secure_websocket configuration example to default plugin file
  • Replaced log with warn for recoverable information to user

@Charles-Schleich Charles-Schleich added the enhancement New feature or request label Oct 24, 2024
@Charles-Schleich Charles-Schleich mentioned this pull request Oct 24, 2024
Merged
@eclipse-zenoh eclipse-zenoh deleted a comment from github-actions bot Oct 24, 2024
@Charles-Schleich Charles-Schleich changed the title Replace static new with JS constructor usage TS API code review Fixes Oct 24, 2024
@Charles-Schleich Charles-Schleich mentioned this pull request Oct 24, 2024
Merged
fuzzypixelz
fuzzypixelz reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@fuzzypixelz fuzzypixelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only unresolved issue is throwing exceptions vs. returning errors. We can address that in a future pull request once further discussed if that's what you were going for.

zenoh-plugin-remote-api/EXAMPLE_CONFIG.json5 Outdated Show resolved Hide resolved
@gabrik gabrik merged commit ebbb056 into eclipse-zenoh:main Oct 29, 2024
9 checks passed
@fuzzypixelz fuzzypixelz mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzzypixelz fuzzypixelz fuzzypixelz left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Charles-Schleich @fuzzypixelz @gabrik