Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new atributes guest perms #1422

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Update new atributes guest perms #1422

merged 1 commit into from
Jul 10, 2024

Conversation

xavier506
Copy link
Collaborator

Update new atributes guest perms

Copy link

@hoji-ai hoji-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

  • Reordered and added new fields for guest role permission in public_producer.yaml
  • Added new columns to guest role permission in public_stat.yaml

Review

Reviewed addition of new fields and reorganization in public_producer.yaml and public_stat.yaml. Verified new fields and ensured proper context and security.

- head_block_producer
- head_block_time
- health_status
- id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The column ordering here shows a reorganization of the fields for the guest role permission. This reordering should be verified to ensure it matches the intended schema and permissions. Ensure newly added fields like is_active, addresshash, and fio_address are intended and properly secured.

- nodes_summary
- tps_all_time_high
- transaction_history
- unique_locations
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New columns last_round, missed_blocks, nodes_summary, tps_all_time_high, transaction_history, and unique_locations have been added to the guest role permission. Verify these additions for correctness in context to guest permissions to ensure no sensitive data exposure is happening.

Copy link
Collaborator

@Torresmorah Torresmorah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit ccc5897 into dev Jul 10, 2024
4 checks passed
@xavier506 xavier506 deleted the fix/hasura-perms branch July 10, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants