Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new atributes guest perms #1422

Merged
merged 1 commit into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 26 additions & 23 deletions hasura/metadata/databases/default/tables/public_producer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,44 +22,47 @@ select_permissions:
- role: guest
permission:
columns:
- block_cpu_limit
- block_net_limit
- block_rewards
- bp_json
- is_active
- addresshash
- bp_json_url
- chain_id
- created_at
- endpoints
- fio_address
- fork_db_head_block_id
- fork_db_head_block_num
- head_block_id
- head_block_num
- head_block_producer
- head_block_time
- health_status
- id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The column ordering here shows a reorganization of the fields for the guest role permission. This reordering should be verified to ensure it matches the intended schema and permissions. Ensure newly added fields like is_active, addresshash, and fio_address are intended and properly secured.

- is_active
- last_claim_time
- last_bpclaim
- last_irreversible_block_id
- last_irreversible_block_num
- location
- owner
- ping
- producer_authority
- producer_key
- rank
- server_full_version_string
- server_version
- server_version_string
- total_rewards
- total_votes
- total_votes_eos
- total_votes_percent
- unpaid_blocks
- updated_at
- url
- block_cpu_limit
- block_net_limit
- fork_db_head_block_num
- head_block_num
- id
- last_irreversible_block_num
- location
- ping
- rank
- unpaid_blocks
- virtual_block_cpu_limit
- virtual_block_net_limit
- bp_json
- endpoints
- health_status
- producer_authority
- block_rewards
- total_rewards
- total_votes_eos
- total_votes_percent
- vote_rewards
- created_at
- head_block_time
- last_claim_time
- updated_at
filter: {}
allow_aggregations: true
17 changes: 10 additions & 7 deletions hasura/metadata/databases/default/tables/public_stat.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,25 @@ select_permissions:
- role: guest
permission:
columns:
- last_round
- missed_blocks
- nodes_summary
- tps_all_time_high
- transaction_history
- unique_locations
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New columns last_round, missed_blocks, nodes_summary, tps_all_time_high, transaction_history, and unique_locations have been added to the guest role permission. Verify these additions for correctness in context to guest permissions to ensure no sensitive data exposure is happening.

- average_cpu_usage_in_last_day
- average_cpu_usage_in_last_hour
- average_cpu_usage_in_last_week
- average_daily_transactions_in_last_week
- average_net_usage_in_last_day
- average_net_usage_in_last_hour
- average_net_usage_in_last_week
- created_at
- id
- missed_blocks
- nodes_summary
- tps_all_time_high
- transaction_history
- transactions_in_last_day
- transactions_in_last_hour
- transactions_in_last_week
- unique_locations
- created_at
- last_block_at
- missed_blocks_checked_at
- updated_at
- id
filter: {}
Loading