Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor but critical tweaks to default options for DetailLine + Vendor objects #334

Merged
merged 5 commits into from
Jan 3, 2024

Conversation

jaredthecoder
Copy link
Contributor

@jaredthecoder jaredthecoder commented Dec 24, 2023

As part of Uncat's participation in Intuit's developer growth program, I discovered a major issue with how taxes for non-US locales and this library interact where b/c of the TaxAmount setting being set to 0 in the detailline.py object, I silently would get incorrect tax calculations for non-US clients (e.g. we have many Canadian and UK clients where this presented an issue).

The other update here is to by default not create vendor's as a W9 entity when creating them. A customer raised this to us and upon checking if QBO creates vendors with that checkbox checked, it does not, but this library does. That commit sets the appropriate field to False based on QBO's default of False.

Thank you for keeping up all the hard work on this @ej2! Since I started Uncat nearly 5 years ago, this library has been in my toolkit since day 0! :)

@jaredthecoder
Copy link
Contributor Author

I keep getting pylint errors in the test runs (that's the last commit) failing. Maybe you can advise on the issue there as I don't see that step in the actions for the main repository.

@ej2 ej2 changed the base branch from master to 0.9.6 January 3, 2024 19:44
@ej2 ej2 merged commit cbb974d into ej2:0.9.6 Jan 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants