Minor but critical tweaks to default options for DetailLine + Vendor objects #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of Uncat's participation in Intuit's developer growth program, I discovered a major issue with how taxes for non-US locales and this library interact where b/c of the TaxAmount setting being set to 0 in the
detailline.py
object, I silently would get incorrect tax calculations for non-US clients (e.g. we have many Canadian and UK clients where this presented an issue).The other update here is to by default not create vendor's as a W9 entity when creating them. A customer raised this to us and upon checking if QBO creates vendors with that checkbox checked, it does not, but this library does. That commit sets the appropriate field to
False
based on QBO's default of False.Thank you for keeping up all the hard work on this @ej2! Since I started Uncat nearly 5 years ago, this library has been in my toolkit since day 0! :)