[azure] blob storage instrumentation #1100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Structure is: <Storage Account Name>.blob.core.windows.net We could parse it to get storage-account-name + service (blob, in this case), but the information also seems to be available in the path of the constructed url.
This reverts commit 33bc894.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
Some of the azure go sdk modules require go1.14
go vet fails when run on a directory with no buildable files, eg. running go vet with a version of go too low for the provided dir.
solves the problem when we are attempting to go vet a module, but the version of go we are using isn't supported.
stuartnelson3
commented
Aug 17, 2021
|
this PR is using the incorrect sdk library; it should be using github.com/Azure/azure-storage-blob-go, and not github.com/Azure/azure-sdk-for-go/sdk/storage/armstorage. A lot of the code here will transfer over, but have to be hooked in slightly differently, owing to the different API. I'll close this PR and open a new one. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instrumentation for azure's blob storage. This will probably change as additional services are instrumented and patterns/abstractions start to appear.
There is also queue, table, and file share storage. These will be added in separate PRs.
requested in #885