Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure] blob storage instrumentation #1100

Closed
wants to merge 17 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ endif

.PHONY: check-vet
check-vet:
@for dir in $(shell scripts/moduledirs.sh); do (cd $$dir && go vet ./...) || exit $$?; done
scripts/check_vet.sh

.PHONY: install
install:
Expand Down
20 changes: 0 additions & 20 deletions module/apmazure/doc.go

This file was deleted.

15 changes: 15 additions & 0 deletions scripts/check_vet.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/usr/bin/env bash
set -e

for dir in $(scripts/moduledirs.sh); do
(
cd $dir
# Before go1.13, there was a bug that prevented the toolchain from
# finding a module when no buildable files were present.
# In go1.14 this is detected and the message states that build
# constraints exclude all Go files.
go list -json 2>&1 | grep -E 'build constraints exclude|cannot find module' > /dev/null
[ "$?" = "0" ] && echo "skipping $dir: no buildable Go files" && exit 0
stuartnelson3 marked this conversation as resolved.
Show resolved Hide resolved
go vet ./...
) || exit $?
done