-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement isCompressionEligable method #2656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
agent-nodejs
Make available for APM Agents project planning.
label
Apr 21, 2022
trentm
requested changes
Apr 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implements: #2604
If you use Closes
, Fixes
, or Resolves
then GitHub will automatically link this PR to the issue. Unless you intentionally don't want that?
- HTTP 2 requests will now propagate the the trace context headers
Nice. This is: #1830
- Span compression is enabled by default
This section of "configuration.asciidoc" should be updated for it being on by default now:
[[span-compression-enabled]]
==== `spanCompressionEnabled`
...
trentm
approved these changes
Apr 26, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: #2604
This PR finishes up the span compression work by implementing an
isCompressionEligible
method that uses propagated trace context headers, exit span, and outcome to determine whether a span is eligible for compression. It also ties up a few other loose ends that came up while implementing it.Checklist
[ ] Update TypeScript typings