fix: do not overwrite registries when publishing otel metrics to beats #15517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update apm-server registry mapping logic to avoid overwriting onkey handlers
kruskall
added
the
backport-skip
kruskall
added
backport-9.0
simitt
reviewed
Feb 3, 2025
|
Thank you for the feedback! 🙇 Added 👍 |
1pkg
approved these changes
Feb 3, 2025
2 tasks
mergify bot
added a commit
that referenced
this pull request
Feb 4, 2025
#15517) (#15537) * fix: do not overwrite registries when publishing otel metrics to beats update apm-server registry mapping logic to avoid overwriting onkey handlers * test: add unit test for apm-server mapping logic (cherry picked from commit 9350ef5) Co-authored-by: kruskall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
update apm-server registry mapping logic to avoid overwriting onkey handlers
discovered while backporting the otel changes. Already added in 8.x
if metrics have similar paths the onkey handler is overwritten. To avoid this process all the metrics path first to build a tree and produce them in order.
Checklist
For functional changes, consider:
How to test these changes
Related issues