Update NOTICE.txt to include link to certifi source #1679
Conversation
| @@ -1,2 +1,4 @@ | |||
| connectors-py | |||
| Elastic Python connectors | |||
There was a problem hiding this comment.
Not sure whether this is our official product name.
There was a problem hiding this comment.
This should be just the name of the repository, following our open-source guidelines (so connectors-python). I subtly remember this discussion with @gtback but don't remember where it was
There was a problem hiding this comment.
According to the NOTICE.txt requirement for single-licence repo, it should be the product name:
{Product Name}
Copyright 2012-2018 Elasticsearch B.V.
One example: https://github.com/elastic/elasticsearch-ruby/blob/main/NOTICE
There was a problem hiding this comment.
Ha didn't know, makes sense!
There was a problem hiding this comment.
It doesn't make a huge difference what goes there, but I would generally lean towards what we call the product , not the name of the repo, in the case that those two things are different. I think this is fine.
| @@ -1,2 +1,4 @@ | |||
| connectors-py | |||
| Elastic Python connectors | |||
| Copyright 2022 Elasticsearch B.V. | |||
There was a problem hiding this comment.
Should this be
| Copyright 2022 Elasticsearch B.V. | |
| Copyright 2022-2023 Elasticsearch B.V. |
There was a problem hiding this comment.
I didn't find any doc about this, but my understanding is it's a range from when the software was first developed to the current year. cc @elastic/open-source-wg
| @@ -1,2 +1,4 @@ | |||
| connectors-py | |||
| Elastic Python connectors | |||
There was a problem hiding this comment.
This should be just the name of the repository, following our open-source guidelines (so connectors-python). I subtly remember this discussion with @gtback but don't remember where it was
| @@ -1,2 +1,4 @@ | |||
| connectors-py | |||
| Elastic Python connectors | |||
| Copyright 2022 Elasticsearch B.V. | |||
@gtback confirmed:
|
Connector service uses a transitive library certifi, which is under Mozilla Public License 2.0 (MPL 2.0). MPL 2.0 is in yellow list:
This PR adds the link to certifi source in NOTICE.txt
Checklists
Pre-Review Checklist
v7.13.2,v7.14.0,v8.0.0)