Update NOTICE.txt to include link to certifi source #1679
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,2 +1,4 @@ | ||||||
| Elastic Python connectors | ||||||
| Copyright 2022 Elasticsearch B.V. | ||||||
|
There was a problem hiding this comment. Should this be
Suggested change
There was a problem hiding this comment. I didn't find any doc about this, but my understanding is it's a range from when the software was first developed to the current year. cc @elastic/open-source-wg |
||||||
|
|
||||||
| The software uses 3rd-party library certifi, transitively, which is under Mozilla Public License 2.0 (MPL 2.0). The source code to this library is https://github.com/certifi/python-certifi. | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether this is our official product name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be just the name of the repository, following our open-source guidelines (so
connectors-python). I subtly remember this discussion with @gtback but don't remember where it wasThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the
NOTICE.txtrequirement for single-licence repo, it should be the product name:One example: https://github.com/elastic/elasticsearch-ruby/blob/main/NOTICE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha didn't know, makes sense!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make a huge difference what goes there, but I would generally lean towards what we call the product , not the name of the repo, in the case that those two things are different. I think this is fine.