Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PostgreSQL] Advanced Sync rules #1691

Merged
merged 4 commits into from
Sep 29, 2023

Conversation

moxarth-rathod
Copy link
Contributor

Closes #1690

This PR introduces advanced filtering rules for PostgreSQL by queries to filter out document based on that
Added documentation with several examples illustrating the syntax, how a basic use case works
Included tooltip on the configurable fields that are ignored when advanced sync rules are used

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes

Release Note

For existing PostgreSQL connectors, the next sync after the upgrade will delete all the existing documents and reindex them with different document IDs.

@moxarth-rathod
Copy link
Contributor Author

buildkite test this

@moxarth-rathod moxarth-rathod marked this pull request as ready for review September 27, 2023 12:38
@moxarth-rathod moxarth-rathod requested a review from a team September 27, 2023 12:38
wangch079
wangch079 previously approved these changes Sep 29, 2023
Copy link
Member

@wangch079 wangch079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a small nit

connectors/sources/postgresql.py Outdated Show resolved Hide resolved
@parth-crest
Copy link
Collaborator

buildkite test this

@parth-elastic parth-elastic merged commit cfa3985 into elastic:main Sep 29, 2023
@github-actions
Copy link

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 1691 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres - Sync Rules
5 participants