-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automation] Bump Golang version to 1.24.0 #6872
base: main
Are you sure you want to change the base?
[Automation] Bump Golang version to 1.24.0 #6872
Conversation
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
Made with ❤️️ by updatecli
how did I generate this? diff --git a/.ci/updatecli/updatecli-bump-golang.yml b/.ci/updatecli/updatecli-bump-golang.yml
index be86caf4d2..ea4daf3a01 100644
--- a/.ci/updatecli/updatecli-bump-golang.yml
+++ b/.ci/updatecli/updatecli-bump-golang.yml
@@ -67,13 +67,6 @@ conditions:
tag: '{{ source "latestGoVersion" }}'
sourceid: latestGoVersion
- goDefaultVersion-check:
- name: Check if defined golang version differs
- kind: shell
- sourceid: latestGoVersion
- spec:
- command: 'grep -v -q {{ source "latestGoVersion" }} .go-version #'
-
targets:
update-go-version:
name: "Update .go-version"
diff --git a/.go-version b/.go-version
index 2560439f07..53cc1a6f92 100644
--- a/.go-version
+++ b/.go-version
@@ -1 +1 @@
-1.22.12
+1.24.0 $ GITHUB_TOKEN=$(gh auth token) \
GITHUB_ACTOR=v1v \
updatecli apply --config .ci/updatecli/updatecli-bump-golang.yml --values .ci/updatecli/values.d/scm.yml |
.golangci.yml
Outdated
@@ -130,7 +130,7 @@ linters-settings: | |||
|
|||
gosimple: | |||
# Select the Go version to target. The default is '1.13'. | |||
go: "1.22.12" | |||
go: "1.24.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these can be removed, see #5309
the default is whatever is in the go.mod file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
This PR won't supersede #5309 - I only raised it to see if the golang-crossbuild changes worked fine after enabling 1.24.0
@@ -196,7 +196,7 @@ steps: | |||
artifact_paths: | |||
- "build/TEST-go-unit.cov" | |||
agents: | |||
image: "golang:1.22.6" | |||
image: "golang:1.24.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just created #6893
|
It requires the version to be bumped first in golang-crossbuild project, then a new release will be added to:
https://github.com/elastic/golang-crossbuild/releases/tag/v1.24.0.
Otherwise it will fail until the docker images are available.
Bump golang-version to latest version
Update .golangci.yml
1 file(s) updated with "1.24.0": * .golangci.yml
1.24.0
Update version.asciidoc
1 file(s) updated with ":go-version: 1.24.0": * version/docs/version.asciidoc
1.24.0
Update from dockerfiles
2 file(s) updated with "ARG GO_VERSION=1.24.0": * Dockerfile * Dockerfile.skaffold
1.24.0
Update go.mod version
1 file(s) updated with "go 1.24.0": * go.mod
1.24.0
Update .go-version
1 file(s) updated with "1.24.0": * .go-version
1.24.0
Created automatically by Updatecli
Options:
Most of Updatecli configuration is done via its manifest(s).
Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!