Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automation] Bump Golang version to 1.24.0 #6872

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
+41 −21
Draft

[Automation] Bump Golang version to 1.24.0 #6872

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
34c8d3b
chore: Update go.mod version
v1v Feb 14, 2025
b6c8292
chore: Update .golangci.yml
v1v Feb 14, 2025
d5e4b52
chore: Update .go-version
v1v Feb 14, 2025
c72f2f3
chore: Update from dockerfiles
v1v Feb 14, 2025
f26b3d0
chore: Update version.asciidoc
v1v Feb 14, 2025
05bf572
remove golang references
v1v Feb 17, 2025
8f24598
add changelog
v1v Feb 17, 2025
acd2e13
bumpv ersion pipeline
v1v Feb 17, 2025
dc2ed5d
bump versions golangci
v1v Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .go-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.22.12
1.24.0
8 changes: 4 additions & 4 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ linters-settings:

gosimple:
# Select the Go version to target. The default is '1.13'.
go: "1.22.12"
go: "1.24.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can be removed, see #5309

the default is whatever is in the go.mod file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

This PR won't supersede #5309 - I only raised it to see if the golang-crossbuild changes worked fine after enabling 1.24.0


nolintlint:
# Enable to ensure that nolint directives are all used. Default is true.
Expand All @@ -146,17 +146,17 @@ linters-settings:

staticcheck:
# Select the Go version to target. The default is '1.13'.
go: "1.22.12"
go: "1.24.0"
checks: ["all"]

stylecheck:
# Select the Go version to target. The default is '1.13'.
go: "1.22.12"
go: "1.24.0"
checks: ["all"]

unused:
# Select the Go version to target. The default is '1.13'.
go: "1.22.12"
go: "1.24.0"

gosec:
excludes:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG GO_VERSION=1.22.12
ARG GO_VERSION=1.24.0
FROM circleci/golang:${GO_VERSION}


Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.skaffold
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG GO_VERSION=1.22.12
ARG GO_VERSION=1.24.0
ARG crossbuild_image="docker.elastic.co/beats-dev/golang-crossbuild"
ARG AGENT_VERSION=8.9.0-SNAPSHOT
ARG AGENT_IMAGE="docker.elastic.co/beats/elastic-agent"
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/elastic/elastic-agent

go 1.22.12
go 1.24.0

require (
github.com/Jeffail/gabs/v2 v2.6.0
Expand Down
2 changes: 1 addition & 1 deletion version/docs/version.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// FIXME: once elastic.co docs have been switched over to use `main`, remove
// the `doc-site-branch` line below as well as any references to it in the code.
:doc-site-branch: master
:go-version: 1.22.12
:go-version: 1.24.0
:release-state: unreleased
:python: 3.7
:docker: 1.12
Expand Down
Loading