[APM] fixes incorrect values in service overview throughput chart #89348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
ogupte
added
release_note:skip
sorenlouv
reviewed
Jan 26, 2021
sorenlouv
reviewed
Jan 26, 2021
sorenlouv
reviewed
Jan 26, 2021
x-pack/plugins/apm/server/lib/observability_overview/get_transaction_coordinates.ts
Outdated
Show resolved
Hide resolved
sorenlouv
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
lgtm! Thanks for the quick fix.
Only added a few nits - nothing blocking. Feel free to merge.
Btw. Can you verify if we have API test coverage everywhere you use getTpmRate? Just to make sure nothing breaks.
Easiest is probably to remove the call to the helper, and verify that an API test fails
sorenlouv
approved these changes
Jan 27, 2021
|
i reverted all the consolidation in this PR to cut down on backport conflicts, created a new issue for that to live: #89486. |
sorenlouv
approved these changes
Jan 27, 2021
|
retest |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jan 29, 2021
…astic#89348) * [APM] fixes incorrect values in service overview throughput chart
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Jan 29, 2021
…astic#89348) * [APM] fixes incorrect values in service overview throughput chart # Conflicts: # x-pack/test/apm_api_integration/tests/services/__snapshots__/throughput.snap
ogupte
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89350 by calculating the correct TPM rate for the throughput chart.