Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] fixes incorrect values in service overview throughput chart #89348

Merged
merged 9 commits into from
Jan 29, 2021
Merged

[APM] fixes incorrect values in service overview throughput chart #89348

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cf3bd39
[APM] fixes incorrect values in service overview throughput chart
ogupte Jan 26, 2021
301801d
Consolidates various throughput rate calculations to one helper function
ogupte Jan 26, 2021
b3c0abc
PR feedback and test snapshot update
ogupte Jan 27, 2021
b628724
Revert "PR feedback and test snapshot update"
ogupte Jan 27, 2021
534efb2
Revert "Consolidates various throughput rate calculations to one help…
ogupte Jan 27, 2021
81615ca
Merge branch 'master' into apm-fix-throughput-chart-overview
ogupte Jan 27, 2021
8d4a50a
Merge remote-tracking branch 'upstream/master' into apm-fix-throughpu…
ogupte Jan 28, 2021
df0db70
update api integration snapshot
ogupte Jan 28, 2021
ee53698
Merge branch 'master' into apm-fix-throughput-chart-overview
kibanamachine Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions x-pack/plugins/apm/server/lib/services/get_throughput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,17 @@ interface Options {

type ESResponse = PromiseReturnType<typeof fetcher>;

function transform(response: ESResponse) {
function transform(response: ESResponse, options: Options) {
const { end, start } = options.setup;
const deltaAsMinutes = (end - start) / 1000 / 60;
ogupte marked this conversation as resolved.
Show resolved Hide resolved
if (response.hits.total.value === 0) {
return [];
}
const buckets = response.aggregations?.throughput.buckets ?? [];
return buckets.map(({ key: x, doc_count: y }) => ({ x, y }));
return buckets.map(({ key: x, doc_count: y }) => ({
x,
y: y / deltaAsMinutes,
}));
}

async function fetcher({
Expand Down Expand Up @@ -82,6 +87,6 @@ async function fetcher({

export async function getThroughput(options: Options) {
return {
throughput: transform(await fetcher(options)),
throughput: transform(await fetcher(options), options),
};
}