-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(electric): Add support for the float4 column type #657
Conversation
VAX-846 Implement support for float4 type
|
99b93ef
to
54c6fa0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a fun one. great stuff. are we numerically complete now?
Good one. We still have Postgres' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
This PR adds client-side support for float4. Numbers provided by the user are rounded to the nearest float4 representation using `Math.fround()`. Similarly, when numbers are read from a float4 column in the DB they are rounded to the nearest float4 representation. This would not strictly be necessary if all writes happen through the DAL but because of SQLite's dynamic typing, users can write larger/smaller numbers to float4 columns in which case we would read numbers that fall out of range.
8db1206
to
136d192
Compare
No description provided.