Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(electric): Add support for the float4 column type #657

Merged
merged 7 commits into from
Nov 29, 2023
Merged

feat(electric): Add support for the float4 column type #657

merged 7 commits into from
Nov 29, 2023

Commits on Nov 29, 2023

  1. Add support for the float4 type on the server

    @alco
    alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    a779512 View commit details
    Browse the repository at this point in the history

  2. Update the e2e test for floats to include float4

    @alco
    alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    d918cd5 View commit details
    Browse the repository at this point in the history

  3. add changeset

    @alco
    alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    70840b7 View commit details
    Browse the repository at this point in the history

  4. Fix a typo in the changeset

    @alco
    alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    daeb5ae View commit details
    Browse the repository at this point in the history

  5. feat (DAL): client-side support for float4 (#671) 

    This PR adds client-side support for float4.
Numbers provided by the user are rounded to the nearest float4
representation using `Math.fround()`.
Similarly, when numbers are read from a float4 column in the DB they are
rounded to the nearest float4 representation.
This would not strictly be necessary if all writes happen through the
DAL but because of SQLite's dynamic typing, users can write
larger/smaller numbers to float4 columns in which case we would read
numbers that fall out of range.
    @kevin-dp @alco
    kevin-dp authored and alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    ba8afe9 View commit details
    Browse the repository at this point in the history

  6. Remove the mention of float4 from the docs for now

    @alco
    alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    b8f3863 View commit details
    Browse the repository at this point in the history

  7. Update changeset

    @alco
    alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    136d192 View commit details
    Browse the repository at this point in the history