feat(electric): Add support for the JSONB column type #661
Conversation
VAX-825 Implement support for json and jsonb types
|
| @@ -512,6 +512,11 @@ defmodule Electric.Satellite.Serialization do | |||
| val | |||
| end | |||
|
|
|||
| def decode_column_value!(val, type) when type in [:json, :jsonb] do | |||
| _ = Jason.decode!(val) | |||
There was a problem hiding this comment.
shame to have to do a full decode with all those allocations just to test the syntax but for now it makes sense
There was a problem hiding this comment.
Oh yes, this is tragic. Ideally we'd use a native library that only validates JSON, without any allocations. It's surprisingly difficult to find one because googling for it yields results about validating json schema.
Alternatively, and I don't know how feasible it is, but maybe we could pull the JSON validation code (directly from Postgres)[https://github.com/postgres/postgres/blob/50c67c2019ab9ade8aa8768bfe604cd802fe8591/src/backend/utils/adt/json.c#L1625] and wrap it into a NIF. The maintanence burden of that would be low, especially when taking into account that we currently have uncovered edge cases where Jason.decode!() would treat a given JSON as valid while Postgres would reject it.
This PR adds client-side support for the JSON type. The DAL accepts JS values representing JSON and serialises them to a string that is stored in SQLite. When reading a JSON value from the database the string is deserialised back into a JS value. A corner case arises when having an optional column of type JSON because we need to differentiate between the database NULL value and the JSON null value. We treat the regular JS null value as a database NULL (to be consistent with how null values are interpreted for other column types) and require users to pass a special JsonNull object in order to store a top-level JSON null value. Still need to add an E2E test for json values. --------- Co-authored-by: Oleksii Sholik <[email protected]>
alco
force-pushed
the
alco/vax-825-add-support-for-jsonb
branch
from
b1a30e0
to
5a0a033
Compare
|
Did you see that sqlite will soon support jsonb? https://sqlite.org/draft/jsonb.html |
No description provided.