Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(electric): Add support for the JSONB column type #661

Merged
merged 6 commits into from
Nov 29, 2023
Merged

feat(electric): Add support for the JSONB column type #661

merged 6 commits into from
Nov 29, 2023

Commits on Nov 29, 2023

  1. feat(electric): Add support for the JSONB column type

    @alco
    alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    7128a9d View commit details
    Browse the repository at this point in the history

  2. add changeset

    @alco
    alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    e700540 View commit details
    Browse the repository at this point in the history

  3. feat(DAL): client-side support for JSON type (#633) 

    This PR adds client-side support for the JSON type.
The DAL accepts JS values representing JSON and serialises them to a
string that is stored in SQLite.
When reading a JSON value from the database the string is deserialised
back into a JS value.
A corner case arises when having an optional column of type JSON because
we need to differentiate between the database NULL value and the JSON
null value. We treat the regular JS null value as a database NULL (to be
consistent with how null values are interpreted for other column types)
and require users to pass a special JsonNull object in order to store a
top-level JSON null value.

Still need to add an E2E test for json values.

---------

Co-authored-by: Oleksii Sholik <[email protected]>
    @kevin-dp @alco
    kevin-dp and alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    9a5f030 View commit details
    Browse the repository at this point in the history

  4. Update changeset

    @alco
    alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    ef951aa View commit details
    Browse the repository at this point in the history

  5. Fix whitespace problems in the E2E test

    @alco
    alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    5a0a033 View commit details
    Browse the repository at this point in the history

  6. fix formatting

    @alco
    alco committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    6f61746 View commit details
    Browse the repository at this point in the history